Comparing 2 array values push only first result

Question

I have an array which i need to compare it's values - and if there are duplication - i want to store them in array, for example :

 obj1 = [{"manager_id":1,"name":"john"},{"manager_id":1,"name":"kile"},
 {"manager_id":2,"name":"kenny"},
 {"manager_id":4,"name":"stan"}]

 obj2 = [{"employees_id":1,"name":"dan"},
 {"employees_id":1,"name":"ben"},{"employees_id":1,"name":"sarah"},
 {"employees_id":2,"name":"kelly"}]

If "manger_id" === "employees_id - then the result would be :

 // {1:[{"manager_id":1,"name":"john"},{"manager_id":1,"name":"kile"},
    {"employees_id":1,"name":"dan"}, {"employees_id":1,"name":"ben"},
    {"employees_id":1,"name":"sarah"}]};

I've tried :

var obj1 = [{
  "manager_id": 1,
  "name": "john"
}, {
  "manager_id": 1,
  "name": "kile"
}, {
  "manager_id": 2,
  "name": "kenny"
}, {
  "manager_id": 4,
  "name": "stan"
}];

var obj2 = [{
  "employees_id": 1,
  "name": "dan"
}, {
  "employees_id": 1,
  "name": "ben"
}, {
  "employees_id": 1,
  "name": "sarah"
}, {
  "employees_id": 2,
  "name": "kelly"
}];

var res = obj1.concat(obj2).reduce(function(r, o) {

  r[o.manager_id] = r[o.employees_id] || [];
  r[o.manager_id].push(o);


  return r;
}, {});


console.log(res);

.as-console-wrapper {
  max-height: 100% !important;
  top: 0;
}

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>

<div></div>

As you can the results of the "manager_id" aren't added - only one - when there should be more

if manager_id === employees_id // should output in the first key

{1:[{"manager_id":1,"name":"john"},{"manager_id":1,"name":"kile"},
    {"employees_id":1,"name":"dan"}, {"employees_id":1,"name":"ben"},
    {"employees_id":1,"name":"sarah"}]};

As you can see there are several common id's

abhikr7 · Accepted Answer · 2017-12-27 15:19:46Z

3

r[o.manager_id] = r[o.employees_id] || []; in this statement if a manager didn't have an employee_id the array was being reset for that id.

One way doing it right is this:

var res = obj1.concat(obj2).reduce(function(r, o) {
  var id;
  if(o.hasOwnProperty('manager_id')) {
    id = o['manager_id'];
  }
  else {
    id = o['employees_id'];
  }

  r[id] = r[id] || [];
  r[id].push(o);

  return r;
}, {});

answered Dec 27, 2017 at 15:19

abhikr7

1061 silver badge3 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

RoyBarOn Over a year ago

@abnikr7 Thanks - nailed it !

abhikr7 Over a year ago

@RoyBarOn No problem!

RoyBarOn Over a year ago

would you mind to explain this : r[id] = r[id] || []; what is it stands for? thanks

abhikr7 Over a year ago

It is to initialise the array for an id, if it is undefined.

Carlos Valencia · Accepted Answer · 2017-12-27 15:29:48Z

2

The problem relies on this line:

r[o.manager_id] = r[o.employees_id] || [];

You should have in mind that some objects in your arrays have the manager_id and some other don't, they have the employees_id instead, so you have to evaluate that first with this line:

var itemId = o.manager_id || o.employees_id;

Try this code:

var res = obj1.concat(obj2).reduce(function(r, o) {
  var itemId = o.manager_id || o.employees_id;
  r[itemId] = r[itemId] || [];
  r[itemId].push(o);


  return r;
}, {});

edited Dec 27, 2017 at 15:29

answered Dec 27, 2017 at 15:24

Carlos Valencia

7,0532 gold badges32 silver badges46 bronze badges

Collectives™ on Stack Overflow

Comparing 2 array values push only first result

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related