Wordpress - Close connection in php script

Question

I am implementing a script in php for a Wordpress blog. The script should be executed every five minutes. The script opens a mysql connection and I want to close it when I am finished. Can you check if it works?

$db = mysql_connect(DB_HOST, DB_USER, DB_PASSWORD);
mysql_select_db("XY", $db);

//set data into $data

foreach ($data => $info) {
  //do stuff inserts
}

mysql_close();

Is the approach right? I am closing the connection used in this script or I am closing also other connections?

WARNING: Read up on how you can use WPDB with prepared statements that use placeholder values like %s to properly escape your data. DO NOT use the obsolete mysql_query family of functions. Those were removed in PHP 7 because they're exceptionally dangerous and fundamentally broken. — tadman
– tadman, Commented Jan 2, 2018 at 20:51
Do you mean this statement is dangerous? mysql_query("INSERT INTO table1 (column1) VALUES (\"$column1\");"); — MrScf
– MrScf, Commented Jan 2, 2018 at 21:01

Honk der Hase · Accepted Answer · 2018-01-02 22:48:54Z

3

Closing the connection explicitly is not mandatory. PHP cleans up all the resources when the script finishes, this includes database connections or sockets, filehandles, any internal resources like images and last but not least, memory blocks.

answered Jan 2, 2018 at 22:48

Honk der Hase

2,5081 gold badge17 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Frederik Banke · Accepted Answer · 2018-01-02 20:53:36Z

1

You could pass your $db variable to the mysql_close() function call. Like mysql_close($db).

But be aware that the mysql_* are deprecated and will be removed in a future php version. You should look into the mysqli_* functions instead.

answered Jan 2, 2018 at 20:53

Frederik Banke

4824 silver badges16 bronze badges

1 Comment

tadman Over a year ago

Not a future version, it's already happened in PHP 7.0. This is historical fact now. Wordpress also has WPDB, there's absolutely no need to use mysqli.

Collectives™ on Stack Overflow

Wordpress - Close connection in php script

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related