Spring webflux non-blocking response

Question

I have a request method that use 'username' and 'password' body parameters to find real user from database, validate it by using request password and if everything is fine - return generated token as String.

public Mono<ServerResponse> handleLogin(ServerRequest request) {
    User body = request.bodyToMono(User.class).block();
    return userRepository.findById(body.getUsername())
            .filter(user -> passwordEncoder.matches(body.getPassword(), user.getPassword()))
            .flatMap(user -> ServerResponse.ok().body(Mono.just(tokens.store(user)), String.class))
            .switchIfEmpty(ServerResponse.badRequest().build());
}

This method works fine, but i'm trying to make it as non-blocking and i'm not sure how to achieve it. Any help appreciated.

Updated

For now i changed my method content to

    return request.bodyToMono(User.class)
            .flatMap(body -> userRepository.findById(body.getUsername()).flatMap(user -> Mono.just(new Object[]{body.getPassword(), user})))
            .filter(obj -> {
                User user = (User) obj[1];
                return user.isActive() && passwordEncoder.matches((CharSequence) obj[0], user.getPassword());
            })
            .flatMap(obj -> {
                User user = (User) obj[1];
                return ServerResponse.ok().body(Mono.just(tokens.store(user)), String.class);
            })
            .switchIfEmpty(ServerResponse.badRequest().build());

This is non-blocking, but looks like not so elegant solution. Can it be improved/simplified somehow?

Oleh Dokuka · Accepted Answer · 2018-01-08 17:24:50Z

2

Remember

1) Everything is stream.

2) Keep your flow composed

3) No blocking operation at all.

Solution

So, keep your flow composed without blocking operation

public Mono<ServerResponse> handleLogin(ServerRequest request) {

    return request.bodyToMono(User.class)
                  .flatMap(body -> userRepository.findById(body.getUsername())
                  .filter(user -> passwordEncoder.matches(body.getPassword(), user.getPassword()))
                  .flatMap(user -> ServerResponse.ok().body(Mono.just(tokens.store(user)), String.class))
                  .switchIfEmpty(ServerResponse.badRequest().build());
}

Regarding the last update

Regarding the last update, from my point of view, the code might be optimized in a next way:

return request.bodyToMono(User.class)
            .flatMap(body -> userRepository.findById(body.getUsername())                              
                                           .filter(user -> user.isActive())
                                           .filter(user -> passwordEncoder.matches(body.getPassword(), user.getPassword()))
            )
            .flatMap(user -> ServerResponse.ok().syncBody(tokens.store(user)))
            .switchIfEmpty(ServerResponse.badRequest().build());

edited Jan 8, 2018 at 17:24

answered Jan 7, 2018 at 19:25

Oleh Dokuka

12.3k6 gold badges43 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

maksim Over a year ago

In this case .filter(user -> passwordEncoder.matches(body.getPassword(), user.getPassword())) don't know the body, so body.getPassword() will not work here. I need somehow to pass the password parameter from user request to use it inside filter.

Collectives™ on Stack Overflow

Spring webflux non-blocking response

1 Answer 1

Remember

Solution

Regarding the last update

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Remember

Solution

Regarding the last update

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related