Node.js REST API Server update with _id attribute

Question

Im trying to update my REST API using _id attribute but nothing happens if I try to use unique _id. It works if I update my entry uisng parametr like room name or room number. Could somebody help me please? Where do I have a mistake? It makes me just crazy!

app.put('/api/conferenceRooms/:_id&:_name', (req, res) => {
    var id = req.params._id;
    var name = req.params._name;
    var conferenceRoom = req.body;
    ConferenceRoom.updateConferenceRoom(id, name, conferenceRoom, {}, (err, conferenceRoom) => {
        if(err){
            throw err;
        }
        res.json(conferenceRoom);
    });
});


// Update ConferenceRoom
module.exports.updateConferenceRoom = (id, name, conferenceRoom, options, callback) => {
    var query = {_id: id, name:name};
    var update = {
        temperature: conferenceRoom.temperature
    }
    ConferenceRoom.findOneAndUpdate(query, update, options, callback);
}

I checked everything already 1000 times

hopelessmuffins · Accepted Answer · 2018-01-09 02:57:30Z

1

I think it is because you are trying to query _id with a string of the id, but it is likely type ObjectId in MongoDB (default I believe). Try something like:

var ObjectId = require('mongoose').Types.ObjectId; 
var query = { _id: new ObjectId(id) };

answered Jan 9, 2018 at 2:57

hopelessmuffins

3151 silver badge12 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Anna K Over a year ago

It doesnt see my id. In ngrok I can see PUT /api/conferenceRooms/&:_IoT 404 Not Found when I send 349349d1.ngrok.io/api/conferenceRooms/… Headers Content-Type application/json and I add raw body { "temperature" : 4 }

Nuru Salihu · Accepted Answer · 2018-01-09 02:53:57Z

0

Your name is probably undefined or wrong.

change

'/api/conferenceRooms/:_id&:_name'

To

app.put('/api/conferenceRooms/:_id/:_name', (req, res) => {


}

answered Jan 9, 2018 at 2:53

Nuru Salihu

4,98818 gold badges73 silver badges122 bronze badges

Comments

deepak thomas · Accepted Answer · 2018-01-09 06:20:37Z

0

You would have the change Url. As now in

'/api/conferenceRooms/:_id&:_name'

:_id is a Reqest URL Parameter and :_name is Request Query Parameter

What you can do is that you could change both to either Reqest URL or Query Parameter.

When accessing URL Parameter - req.params._id

When accessing Query Parameter - req.query._id

answered Jan 9, 2018 at 6:20

deepak thomas

1,1909 silver badges25 bronze badges

1 Comment

Anna K Over a year ago

if I access req.parms_id in ngrok I see PUT /api/conferenceRooms/&:_IoT 404 Not Found when using req_query._id the same :(

Collectives™ on Stack Overflow

Node.js REST API Server update with _id attribute

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related