java.util.MissingFormatArgumentException: Format specifier: s

Question

I am trying to add data to SQLite database in android, But I am getting error, "java.util.MissingFormatArgumentException: Format specifier: s". I tried to figure out the problem but I can't find it.

Button OnClickListener to add data to database.

 addToCart.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            new Database(getBaseContext()).addToCart(new Order(
                    foodId,
                    foodItem.getName(),
                    quantity.getNumber(),
                    foodItem.getPrice(),
                    foodItem.getDiscount(),
                    foodItem.getImage()
            ));

            Toast.makeText(ItemDetailsActivity.this, "Item added to your basket.", Toast.LENGTH_SHORT).show();

        }
    });

Method to add

  public void addToCart(Order order){
    SQLiteDatabase db = getReadableDatabase();
    String query = String.format("INSERT INTO OrderDetails(Productid,ProductName,Quantity,Price,Discount,Image) VALUES('%s','%s','%s','%s','%s','%s');",
            order.getProductid(),
            order.getProductName(),
            order.getQuantity(),
            order.getPrice(),
            order.getDiscount());
    db.execSQL(query);
}

check database column datatype if integer or decimal then %i or %d — KDD
– KDD, Commented Jan 9, 2018 at 12:52
%d and %i cause error. And Database table is same, except i have ID extra in it, but it is auto generated. — P595
– P595, Commented Jan 9, 2018 at 12:57

laalto · Accepted Answer · 2018-01-09 12:59:41Z

2

String query = String.format("INSERT INTO OrderDetails(Productid,ProductName,Quantity,Price,Discount,Image) VALUES('%s','%s','%s','%s','%s','%s');",
        order.getProductid(),
        order.getProductName(),
        order.getQuantity(),
        order.getPrice(),
        order.getDiscount());

You have six %s format placeholders but you're supplying only five values.

answered Jan 9, 2018 at 12:59

laalto

153k68 gold badges293 silver badges306 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

P595 Over a year ago

I forgot to add Image! Thanks a lot.

Oleksandr Lykhonosov · Accepted Answer · 2018-01-09 13:01:32Z

1

MissingFormatArgumentException

Unchecked exception thrown when there is a format specifier which does not have a corresponding argument or if an argument index refers to an argument that does not exist.

You didn't set a value for the 'Image' parameter

answered Jan 9, 2018 at 13:01

Oleksandr Lykhonosov

1,39813 silver badges28 bronze badges

Collectives™ on Stack Overflow

java.util.MissingFormatArgumentException: Format specifier: s

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related