bash add string from variable using sed

Question

I need to edit a files using shell script (sed), I can't seem to get it to work when I use "space" inside my string.

This is the bash script:

##Edit instancegroup files with relevant cluster
CLUSTER_NAME=clusters.dev10.k8s.local
oldcluster="kops.k8s.io/cluster:"
newcluster="kops.k8s.io/cluster: ${CLUSTER_NAME}"
sed -i 's@'${oldcluster}'@'${newcluster}'@g' myfile

This is myfile:

apiVersion: kops/v1alpha2
kind: InstanceGroup
metadata:
  creationTimestamp: 2018-01-03T10:45:43Z
  labels:
    kops.k8s.io/cluster:

And this is the error I get:

administrator@JenkisSrv01:~/awscluster/instancegroup$ ./try.sh
sed: -e expression #1, char 43: unterminated `s' command

When I removing the space from line 4, it is working well:

newcluster="kops.k8s.io/cluster:${CLUSTER_NAME}"

choroba · Accepted Answer · 2018-01-11 15:25:21Z

3

Unquoted space separates parameters. Quote the variable:

sed -i 's@'"${oldcluster}"'@'"${newcluster}"'@g' myfile

or more readably

sed -i "s@$oldcluster@$newcluster@g" myfile

Note that . has a special meaning in regexes, so kops.k8s.io/cluster: matches e.g. kopsXk8sXio/cluster:. You need to backslash the dots to force the literal meaning.

answered Jan 11, 2018 at 15:25

choroba

245k27 gold badges221 silver badges304 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nahuel Fouilleul · Accepted Answer · 2018-01-11 15:25:13Z

0

add double quotes around variables

sed -i 's@'"${oldcluster}"'@'"${newcluster}"'@g' myfile

answered Jan 11, 2018 at 15:25

Nahuel Fouilleul

19.5k2 gold badges36 silver badges37 bronze badges

Collectives™ on Stack Overflow

bash add string from variable using sed

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related