PHP - DOMDocument - need to change/replace an existing HTML tag w/ a new one

Question

I'm trying to change all <P> tags in a document to <DIV>. This is what I've come up with, but it doesn't seem to work:

$dom = new DOMDocument;
$dom->loadHTML($htmlfile_data);

foreach( $dom->getElementsByTagName("p") as $pnode ) {
    $divnode->createElement("div");
    $divnode->nodeValue = $pnode->nodeValue;
    $pnode->appendChild($divnode);
    $pnode->parentNode->removeChild($pnode);
}

This is the result I want:

Before:

<p>Some text here</p>

After:

<div>Some text here</div>

This works stackoverflow.com/a/21885789/175071

Timo Huovinen
– Timo Huovinen

2014-03-11 13:17:13 +00:00
Commented Mar 11, 2014 at 13:17 — Timo Huovinen
– Timo Huovinen, Commented Mar 11, 2014 at 13:17

Samuel Herzog · Accepted Answer · 2011-01-28 03:23:35Z

9

You are appending the div to your p which results in <p><div></div></p>, removing the p will remove everything.
Additionally $divnode->createElement() won't work when $divnode isn't initialized.

Try instead to use the DOMDocument::replaceChild() (the divs position in the dom will be the same as the ps).

foreach( $dom->getElementsByTagName("p") as $pnode ) {
    $divnode = $dom->createElement("div", $pnode->nodeValue);
    $dom->replaceChild($divnode, $pnode);
}

answered Jan 28, 2011 at 3:23

Samuel Herzog

3,5991 gold badge24 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

i-- Over a year ago

One note: if $pnode->nodeValue is not a plain text, but has extra nodes in it, only text will be left (html will be stripped).

Sanne Over a year ago

You can't just replace items while iterating since the index changes and you end up with weird results.

Samuel Herzog Over a year ago

guess what: I actually tested this at the time I answered it. So in case you use a recent PHP version foreach can handle the manipulation of the index.

fearis Over a year ago

as Sanne said their will be an error for multiple items. Check this answer stackoverflow.com/questions/12018747/…

Community · Accepted Answer · 2017-05-23 12:32:04Z

0

Enhanced function from this answer

function changeTagName( $node, $name ) {
    $childnodes = array();
    foreach ( $node->childNodes as $child ) {
        $childnodes[] = $child;
    }
    $newnode = $node->ownerDocument->createElement( $name );
    foreach ( $childnodes as $child ){
        $child2 = $node->ownerDocument->importNode( $child, true );
        $newnode->appendChild($child2);
    }
    if ( $node->hasAttributes() ) {
        foreach ( $node->attributes as $attr ) {
            $attrName = $attr->nodeName;
            $attrValue = $attr->nodeValue;
            $newnode->setAttribute($attrName, $attrValue);
        }
    }
    $node->parentNode->replaceChild( $newnode, $node );
    return $newnode;
}

edited May 23, 2017 at 12:32

CommunityBot

11 silver badge

answered Oct 7, 2016 at 18:26

elvismdev

1,02511 silver badges23 bronze badges

Collectives™ on Stack Overflow

PHP - DOMDocument - need to change/replace an existing HTML tag w/ a new one

2 Answers 2

4 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related