variables not accessible within function

Question

I have some variables that are not included in the function but just outside of where they are created. I know I can pass them as parameters however I am looking for a more elegant method.

Code:

Tree.prototype.add = function(path){
var pathSplit = path.split('/');
//gets the length of the path
const pathLength = pathSplit.length;
//this compares the path to the nodes/directories
let compare = (currentNode, n) => {
    console.log(n);
    if(n == pathLength -1){
        console.log(pathLength);
        //create a new node with file name as data
        var nodeFile = new Node(pathSplit[n]);
        //adds the file name onto the the node
        currentNode.children.push(nodeFile);
        //sets the node parent to the currentNode
        nodeFile.parent = currentNode;
    }else{
        //console.log('THIS IS RUN');
        var newNode = () => this.traversalBF(currentNode, pathSplit[n]);
           //console.log(newNode);
           compare(newNode, n++);
       };

   };
   compare(this._root, 0);
   };

the variable PathLength is considered to be 0 inside the compare function. however it should be 3 when it is called:

tree.add('one/two/three');

also the code runs like 1000 times not sure why if there is any help on that, that would be nice — help please
– help please, Commented Jan 14, 2018 at 19:13
Not certain what you are trying to achieve? What is the issue with the code at Question? — guest271314
– guest271314, Commented Jan 14, 2018 at 19:18

trincot · Accepted Answer · 2018-01-14 19:34:29Z

1

The problem is that in your recursive call you pass the value of n++. Note that this passes the value of n before it is increased. So you get an infinite recursion-chain where the path length is never reached.

Instead do:

        compare(newNode, n+1);

Note: The value of pathLength is never 0. You log both n and pathLength at different locations in your code, and so you might have confused one for the other. It is n that is 0.

edited Jan 14, 2018 at 19:34

answered Jan 14, 2018 at 19:27

trincot

357k38 gold badges282 silver badges338 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

help please Over a year ago

yes you absolutely correct I did get confused by the n and pathLength I realised that after.

guest271314 · Accepted Answer · 2018-01-14 19:23:24Z

0

PathLength is considered to be 0 inside the compare function. however it should be 3 when it is called

pathLength is declared using const. The value of pathLength cannot be changed. See

You can declare the variable using let and within the function change the value of the variable.

answered Jan 14, 2018 at 19:23

guest271314

1

Collectives™ on Stack Overflow

variables not accessible within function

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related