JSHint warning "Function declared within loop referencing an outer scope variable may lead to confusing semantics" . How can I improve the code?

Question

JSHint shows the error: "Function declared within loop referencing an outer scope variable may lead to confusing semantics". How can I improve the following code to get rid of the warning?

var getPrecedence  = function getPrecedence(operator, operators) {
    var keys = Object.keys(Object(operators));
    for (var i = 0, len = keys.length; i < len; i++) {
        var check = Object.keys(operators[keys[i]]).some(function (item) {
            return item === operator;
    });
    if (check) return operators[keys[i]][operator];
    }
};

It would help us help you if you showed us an example of the structure of operators. Not least because Object(operators) looks quite odd looks quite odd... — T.J. Crowder
– T.J. Crowder, Commented Jan 25, 2018 at 11:49
this.operators = {"operators": { "^": 1, "*": 2, "/": 2, "%": 2, "+": 3, "-": 3, }, "functions": { "log": 0, "sin": 0, "cos": 0, "tan": 0, }, "brackets": { "open": ["("], "close": [")"] }, "equal": { "=": 4 } }; — Kasia
– Kasia, Commented Jan 25, 2018 at 13:05
To improve the question, use the "edit" link under the question, not comments (particularly not when you need code formatting). — T.J. Crowder
– T.J. Crowder, Commented Jan 25, 2018 at 13:07
@Kasia You might want to change your data structure into having a single level only, like {"^": {prec: 1, type: "op"}, "*": {prec: 2, type: "op"}, "log": {prec: 0, type:"fn"}, "(": {prec: 4, type:"open"} or so. (Although your structure for the brackets doesn't seem to fit in there anyway) — Bergi
– Bergi, Commented Jan 25, 2018 at 13:27

Bergi · Accepted Answer · 2018-01-25 13:18:37Z

6

You are supposed not to use the function expression inside the loop body, but instead declare it outside:

function getPrecedence(operator, operators) {
    function isOperator(item) {
//  ^^^^^^^^^^^^^^^^^^^^^^^^^^^
        return item === operator;
    }
    var keys = Object.keys(Object(operators));
    for (var i = 0, len = keys.length; i < len; i++) {
        var check = Object.keys(operators[keys[i]]).some(isOperator);
//                                                       ^^^^^^^^^^
        if (check) return operators[keys[i]][operator];
    }
}

Of course the whole thing could be simplified by just using includes instead of some, and find instead of the loop:

function getPrecedence(operator, operators) {
    var keys = Object.keys(Object(operators));
    var opkey = keys.find(key =>
        Object.keys(operators[key]).includes(operator)
    );
    if (opkey) return operators[opkey][operator];
}

And finally, Object.keys(…).includes(…) can be simplified to operator in operators[key].

answered Jan 25, 2018 at 13:18

Bergi

671k162 gold badges1k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

T.J. Crowder Over a year ago

"And finally, Object.keys(…).includes(…) can be simplified to operator in operators[key]" In this case, though not, of course, in the general case.

Subham Subhasis Patra · Accepted Answer · 2022-05-26 11:32:01Z

1

Add it before calling the function, this one will bypass that check

/* jshint -W083 */

answered May 26, 2022 at 11:32

Subham Subhasis Patra

1299 bronze badges

Collectives™ on Stack Overflow

JSHint warning "Function declared within loop referencing an outer scope variable may lead to confusing semantics" . How can I improve the code?

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related