How to removes an item from an array in java using a method?

Question

I have to create a method that takes in an array and value as arguments and returns a new array with the specified value removed.

Here's my attempt:

public static int[] remove(int[] nums,int value){
    int[] after = new int[nums.length-1];
    for (int i = 0; i < nums.length; i++) {
        if (!(nums[i] == value)) {
            after[i] = nums[i];
        }
    }
    nums = after;
    return nums;
}

The code throws

ArrayIndexOutOfBoundsException

bur I don't know why.

what is your question? Does the above code not work? If so, how does it fail? — kyriakosSt
– kyriakosSt, Commented Feb 10, 2018 at 0:35
If value is not the last element in the nums array you'll get a ArrayIndexOutOfBoundsException since after length is 1 less then num length and i goes as high as nums.length - 1. — Titus
– Titus, Commented Feb 10, 2018 at 0:35
As KyrSt says, you need to add error messages so that this question is helpful to other programmers. What happens when you run it? — sakurashinken
– sakurashinken, Commented Feb 10, 2018 at 0:38

bhazero025 · Accepted Answer · 2018-02-10 00:53:26Z

1

First you need to find how big the new array is, after you can populate the new array without the value to remove. There are better ways to do this, but this is to get you started.

public static int[] remove (int[] nums, int value)
{
    int[] after;

    //find out the length of the array
    int count = 0;
    for (int num : nums)
    {
        if (num != value)
        {
            count++;
        }
    }

    after = new int[count];

    //add all the elements except the remove value
    int i = 0;
    for (int num : nums)
    {
        if(num != value)
        {
            after[i] = num;
            i++;
        }
    }

    return after;
}

answered Feb 10, 2018 at 0:53

bhazero025

3274 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Bohemian · Accepted Answer · 2018-02-10 05:32:19Z

1

KISS. It's a 1-liner:

public static int[] remove(int[] nums, int value){
    return IntStream.stream(nums).filter(i -> i != value).toArray();
}

answered Feb 10, 2018 at 5:32

Bohemian♦

427k103 gold badges604 silver badges750 bronze badges

Comments

rohit_2110 · Accepted Answer · 2018-02-10 04:33:06Z

Code is trying to copy values from original array to new array leaving a blank or space(value 0) in place of targeted value. The error ArrayIndexOutOfBoundsException is showing because you are initialising the after with nums.lenth-1 int[] after = new int[nums.length-1]; You can change that or swap the targeted element with the last element and copy entire array except the last.

public static int[] remove (int[] nums,int value){
    int[] after = new int[nums.length-1];

    for(int i = 0; i < nums.length; i++) {
        if((nums[i] == value)) {
            //changing the target value with the last value of nums array
            nums[i]=nums[nums.length-1];
            nums[nums.length-1]=value;
        }
    }

    //Copying the entire array except the last
    for(int i=0;i<nums.length-1;i++){
        after[i]=nums[i];
    }
    return after;
}

And I am assuming that there is only one target element

Collectives™ on Stack Overflow

How to removes an item from an array in java using a method?

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related