Preventing instanceof and casting in Java [duplicate]

Question

How do I avoid using instanceof and casting in this situation if I want to have different validators where the method signatures differ?

Code

for(BatchValidator validator : validators) {
  try {     
    if (validator instanceof BatchErrorValidator) {
      ((BatchErrorValidator<T>) validator).validate(targets);
    } else if (validator instanceof BatchWarningValidator) {
      ((BatchWarningValidator<T>) validator).validate(targets, header);
    }
  } catch (BatchValidationException e) {
    handleImportExceptions(e, header.getSequenceId());
  }
}

What is BatchValidator? Is this an interface? Does it give a required signature of the validate() method? — Code-Apprentice
– Code-Apprentice, Commented Feb 12, 2018 at 23:00

John3136 · Accepted Answer · 2018-02-12 22:59:54Z

5

Why not make BatchValidator.validate() take 2 args: targets and headers. The individual implementations can decide which of the args they need to use.

This way your calling loop just passes the same parameters to each validator and you don't need instanceof or any casting.

answered Feb 12, 2018 at 22:59

John3136

29.3k4 gold badges55 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Preventing instanceof and casting in Java [duplicate]

1 Answer 1

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Linked

Related