C programming: Freeing nested multidimensional arrays inside structs

Question

EDIT: I'm closing this question due to poor formulation as suggested by coderredoc.

I had a problem with a free function where I mistakenly put the address of a location an argument.

    void freeMemory(Stack stp, int n){
    for(int i=0; i<n; i++){
        free(&(stp.signals[n].intervals));
    }
    free(stp.signals);

}

This is the correct code (look below for more info)

    void freeMemory(Stack stp, int n){
    for(int i=0; i<n; i++){
        free(stp.signals[n].intervals);
    }
    free(stp.signals);

}

user2736738 · Accepted Answer · 2018-02-14 09:38:14Z

2

Always remember one thing, you will pass to free whatever you have allocated using malloc and it's friends.

Here you have passed free(&(stp.signals[i].intervals)); why do you pass the address of stp.signals[i].intervals it's stp.signals[i].intervals which contains the allocated chunk's address. (the starting address of the memory chunk that was just created using *alloc) So free(stp.signals[i].intervals) is the correct way to free it.

To be precise, what you have done here is undefined behavior.

From standard 7.22.3.3p2

The free function causes the space pointed to by ptr to be deallocated, that is, made available for further allocation. If ptr is a null pointer, no action occurs. Otherwise, if the argument does not match a pointer earlier returned by a memory management function, or if the space has been deallocated by a call to free or realloc, the behavior is undefined.

edited Feb 14, 2018 at 9:38

answered Feb 14, 2018 at 3:03

user2736738

31k5 gold badges45 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

C programming: Freeing nested multidimensional arrays inside structs

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related