Setting value of a string on click

Question

I am trying to set a value of a productID field by searching the product name. The search returns the correct results and displays them but when clicking the value is being set as if it is a number.

For exmaple this is what is returned when searching...

pID: "<a class='result' onclick='setID(0001-001-004)' href='#'>Product Code=0001-001-004, White Folding Chair</a>"

When the below result is clicked, the value of the input is set as -4. If the number returned was 0001-002-005 it gets set to -5.

The code for the setID function is...

function setID(pID) {
    var prodCode=toString(pID);     
    $('input#productCode').val(pID);
    var clear="";
    $('div#suggestions').html(clear);
    $('div#suggestions').hide(); 

}

Does anyone have any idea how I can do this. I can not return the id between double or single quotations becasue this is the php that returns the result. as you will see the use of double and single quotes leaves me no way to do it in this way...

$array[] = array (
        "pID" =>"<a class='result' onclick='setID(".$row['ITEMNO'].")' href='#'>Product Code=". $row['ITEMNO'].", " .$row['ITEMDESC']."</a>"
    );

chinloyal · Accepted Answer · 2018-02-27 16:11:48Z

2

You need to add single quotes around the concatenation, like this

$array[] = array (
        "pID" =>"<a class='result' onclick='setID(\'".$row['ITEMNO']."\')' href='#'>Product Code=". $row['ITEMNO'].", " .$row['ITEMDESC']."</a>"
    );

edited Feb 27, 2018 at 16:11

answered Feb 27, 2018 at 15:57

chinloyal

1,1711 gold badge18 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Syscall Over a year ago

Sorry, you're update is still wrong : "SyntaxError: illegal character" on click.

Syscall · Accepted Answer · 2018-02-27 16:08:04Z

1

You're missing double quotes around your value in setID() :

"pID" =>"<a class='result' onclick='setID(\"".$row['ITEMNO']."\")' href='#'>Product Code=". $row['ITEMNO'].", " .$row['ITEMDESC']."</a>"

Because, values are interpreted as numbers : 0001-002-005 = 1-2-5 = -6
instead of "0001-002-005" which is a string.

Or using single quotes (to use double quotes in HTML) :

"pID" => '<a class="result" onclick="setID(\''.$row['ITEMNO'].'\')" href="#">Product Code='. $row['ITEMNO'].', ' .$row['ITEMDESC'].'</a>'

edited Feb 27, 2018 at 16:08

answered Feb 27, 2018 at 15:57

Syscall

19.8k10 gold badges44 silver badges60 bronze badges

5 Comments

AKAust Over a year ago

Got it in one! Thank you so much! I knew i had to wrap it quotes but didn't know how as there was already a mix of double and single quotations.

Syscall Over a year ago

@AKAust I've updated the answer to show you the same string using single quotes.

Dormilich Over a year ago

That's why it may be better to use data-* attributes and define the event listener in the JavaScript and not the HTML.

Andrius Over a year ago

Agree with @Dormilich. Also consider using json_encode() instead of manually printing quotes, then you won't need to worry about it being a number or a string (or any other type) and it will be safer against XSS. And don't forget to escape HTML (e.g. htmlspecialchars())

Dormilich Over a year ago

Mind that json_encode() only works in HTML attributes when single quotes are used (and for HTML double quotes are more common).

Dormilich · Accepted Answer · 2018-02-27 15:58:49Z

1

when clicking the value is being set as if it is a number

Because in JS you have set it as a number, but you need to set it as string:

<a class='result' onclick='setID("0001-001-004")'>Product Code=0001-001-004, White Folding Chair</a>

answered Feb 27, 2018 at 15:58

Dormilich

9275 silver badges11 bronze badges

Collectives™ on Stack Overflow

Setting value of a string on click

3 Answers 3

1 Comment

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related