Allowed memory error in getting data from db in laravel

Question

I'm trying to get all posts from database and show the in a view. The posts that I want are stored in database with post_type = product.

I got this error:

Allowed memory size of 134217728 bytes exhausted (tried to allocate 62918656 bytes)

this is my Model:

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\DB;

class GetPostModel extends Model
{
    /**
     * @param $filed
     * @param $value
     * @return mixed
     */
    static function get_posts_by_filed($filed, $value)
    {
        $result = DB::table('posts')->where($filed, $value);
        return $result;
    }
}

this is what I do in Controller:

public function all_products_page(Request $request)
{

    //getting the products
    $all_products = GetPostModel::get_posts_by_filed('post_type', 'product');
    echo '<pre>';
    print_r($all_products);
    echo '</pre>';
}

You need to add ->get() after your where, or else you're just returning the QueryBuilder object instead of the actual results. — aynber
– aynber, Commented Mar 2, 2018 at 18:27

FULL STACK DEV · Accepted Answer · 2018-03-02 19:17:19Z

2

This is happening because u are missing get()

public function all_products_page(Request $request)
{

//getting the products
$all_products = GetPostModel::get_posts_by_filed('post_type', 'product')->get();
echo '<pre>';
print_r($all_products);
echo '</pre>';
 }

answered Mar 2, 2018 at 19:17

FULL STACK DEV

16k6 gold badges49 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Bogdan Cismariu · Accepted Answer · 2018-03-02 19:06:53Z

It seems that you have too many entries in your database and they all get loaded into PHP memory.

The easy solution would be to increase PHP memory limit:

ini_set('memory_limit', '512M');

The correct solution would be to try to protect your memory usage and restrain from processing all the information at once. Also, keep in mind that sending too much information to the browser might also affect performance on the client side.

A possible approach would be to use pagination. Laravel already has this integrated in the query builder: https://laravel.com/docs/5.6/pagination

If passing through all the posts is absolutely necessary, you might want to chunk results as described in the Eloquent documentation: https://laravel.com/docs/5.6/eloquent#chunking-results

Also, a more Laravel like approach would look something like this:

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;

class Post extends Model
{
    protected $table = 'posts';

    /**
     * Scope a query to only include products
     *
     * @param \Illuminate\Database\Eloquent\Builder $query
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function scopeProducts($query)
    {
        return $query->where('post_type', 'product');
    }
}

And then, your Controller would look like this:

<?php

public function all_products_page(Request $request)
{

    Post::products()->chunk(100, function ($products) {
        foreach ($products as $product) {
            // perform action here.
        }
    });
}

Collectives™ on Stack Overflow

Allowed memory error in getting data from db in laravel

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related