Nested If statement inside another if in php

Question

I am trying to write a function such that if the price is not zero it should check that the variable price_label_before is zero, then if should return a certain format or else return something else.

E.g 1

price_label_before =USD Currency= KES Price=2000

Return USD 2000

E.g 2 price_label_before= null Currency= KES Price=2000

Return KES 2000

Below is the code:

$currency       =   esc_html( get_option('wp_estate_currency_symbol', '') );

$where_currency =   esc_html( get_option('wp_estate_where_currency_symbol', '') );

$price_label_before    =   floatval ( get_post_meta($post_id, 'property_label_before', true) );  

$price  = floatval   ( get_post_meta($post_id, 'property_price', true) );

if ($price != 0 ) {

    if ($price_label_before = 0) {


    $price =wpestate_show_price($post_id,$currency,$where_currency,1);   
     }
     else {
           $myprice = floatval   ( get_post_meta($post_id, 'property_price', true) );

           $price='<span class="price_label price_label_before1">'.$price_label_before. '&nbsp;' .number_format($myprice).'</span><span class="price_label ">'.$price_label.'</span>';  
     }             

}else{

    $price='';

}

And what is the code doing or not doing?

Jay Blanchard
– Jay Blanchard

2018-03-05 19:22:39 +00:00
Commented Mar 5, 2018 at 19:22 — Jay Blanchard
– Jay Blanchard, Commented Mar 5, 2018 at 19:22
@JayBlanchard the code is returning 0 2000

user38208
– user38208

2018-03-05 19:24:50 +00:00
Commented Mar 5, 2018 at 19:24 — user38208
– user38208, Commented Mar 5, 2018 at 19:24

Xhynk · Accepted Answer · 2018-03-05 19:49:10Z

1

Your nested else condition will never be met because you're using the assignment operator in your if statement.

if ($price_label_before = 0) {

Should instead be: ~~if ($price_label_before == 0) {~~

Edit: Update to reflect empty condition instead of 0 condition

if ($price_label_before == '' ) {

Or:

if ( empty( $price_label_before ) ) {

Right now, it's setting $price_label_before to 0, and then checking if it's 0 (which is always the case)

This is a difference between an Assignment Operator and Comparison Operator (Specifically the equality operator)

As a (partly irrelevant to the question) sidenote, I'd try and work on your code consistency with spacing and whitespace to make your code more legible. It seems like you've got lots of random spaces and breaks in your code that will make it hard to read and maintain as your codebase grows larger.

$currency       =   esc_html( get_option( 'wp_estate_currency_symbol', '' ) );
$where_currency =   esc_html( get_option( 'wp_estate_where_currency_symbol', '' ) );

$price_label_before = floatval( get_post_meta( $post_id, 'property_label_before', true ) );  
$price              = floatval( get_post_meta( $post_id, 'property_price', true ) );

if( $price != 0 ){
    if( $price_label_before == '' ){
        $price = wpestate_show_price( $post_id, $currency, $where_currency, 1 );   
    } else {
        $myprice = floatval( get_post_meta( $post_id, 'property_price', true ) );
        $price   = '<span class="price_label price_label_before1">'. $price_label_before .'&nbsp;'. number_format( $myprice ) .'</span><span class="price_label ">'. $price_label .'</span>';  
    }
} else {
    $price = '';
}

edited Mar 5, 2018 at 19:49

answered Mar 5, 2018 at 19:24

Xhynk

13.9k8 gold badges36 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user38208 Over a year ago

this still doesn't seem to work the result that is outputted is still returning USD KES 2000, when it is only meant to be USD 2000 or KES 2000 depending on whether $price_label_before is empty or not

Xhynk Over a year ago

Currently you're comparing it to the value 0 which isn't empty. I've updated the large code block to compare it to an empty value instead

Xhynk Over a year ago

To compare to an empty value, you can use $price_label_before == '' or empty( $price_label_before );

Collectives™ on Stack Overflow

Nested If statement inside another if in php

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related