How do i sort an array in a function using pointer notation and the bubble sort algorithm in C

Question

I'm trying to sort 6 numbers input by the user using a bubble sort algorithm. My program has to be modular so I've written the program as a separate function but I keep getting two errors and I have no idea how to correct them.

Error 1. Lvalue required in function sort_Nums(int *)

Error 2. Expression syntax in function sort_Nums(int *)

Here's my code:

void sort_Nums(int*picked_nums)
{
    int i,step,temp;

    for(step=0; step<SIZE-1; ++step)
        for(i=0; i<SIZE-step-1; ++i)
        {
            if(*(picked_nums+i) > *(picked_nums+i)+1)
            {
                temp=*(picked_nums+i);
                *(picked_nums+i) = *(picked_nums+i)+1;
                *(picked_nums+i)+1 = temp;
            }
        }

        printf("The numbers you chose in order are:\n");
        for(i=0; i=<SIZE; ++i)
        {
            printf("%d\n", *(picked_nums+i));
        }   

        printf("Press any key to return to main menu");
        getchar();
    }

Thanks in advance and I am sorry if this is a stupid question and its just a syntax error or something but I've been coding for 9 hours almost now and this assignment is due tomorrow so this is a kind of last resort thing.

You should start using brackets. By the way I mean This =< — Michi
– Michi, Commented Mar 10, 2018 at 17:26
This =>> *(picked_nums + (i + 1 ) is what you need, I think. — Michi
– Michi, Commented Mar 10, 2018 at 17:28
I normally do but i was basing the algorithm off notes from college and my algorithms lecturer codes strangely — Salman Mukadam
– Salman Mukadam, Commented Mar 10, 2018 at 17:30

Abhijit Pritam Dutta · Accepted Answer · 2018-03-10 17:38:38Z

1

Hi your if condition if(*(picked_nums+i)>*(picked_nums+i)+1) is wrong it should be if(*(picked_nums+i)>*(picked_nums+i+1)). As per bubble short logic you need to compare with next element in the array. Like

if (arr[1] > arr[2] )

and you are doing

if (arr[1] > arr[1] + 1 ) which is wrong.

Suppose arr[1] = 4 and arr[2]=3

with the below if condition it should swipe

if (arr[1] > arr[1+1] ) because it is if (4 > 3) which is true

But your if condition is doing like below

if (arr[1] > arr[1] + 1) which is equal to if (4 > 3+1 ) which is false

edited Mar 10, 2018 at 17:38

answered Mar 10, 2018 at 17:29

Abhijit Pritam Dutta

5,6112 gold badges13 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Salman Mukadam Over a year ago

Thanks! This fixed the errors and the code works other than an additional 1 in the output at the end of the sorted numbers Edit: fixed by changing the for(i=0;i<=SIZE;++i) to for(i=0;i<SIZE;++i)

Janne Tuukkanen · Accepted Answer · 2018-03-10 17:41:55Z

0

Here you are adding 1 to the value, not to the pointer, and the second line causes the Lvalue error:

*(picked_nums+i)=*(picked_nums+i)+1;
*(picked_nums+i)+1=temp;

Corrected code would be like this:

*(picked_nums+i)=*(picked_nums+i+1);
*(picked_nums+i+1)=temp;

edited Mar 10, 2018 at 17:41

answered Mar 10, 2018 at 17:32

Janne Tuukkanen

1,66012 silver badges13 bronze badges

1 Comment

Michi Over a year ago

I'd recommend using array syntax Why would you recommend that if the OP says explicit that he need that Pointer notation? ==>> How do i sort an array in a function using pointer notation Have you even read the OPs title?

Collectives™ on Stack Overflow

How do i sort an array in a function using pointer notation and the bubble sort algorithm in C

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related