Django Rest framework conditional delete

Question

[SOLVED]

I just solved like this

class articleViewSet(viewsets.ModelViewSet):
    queryset = article.objects.all()
    serializer_class = articleSerializer

    def destroy(self, request, *args, **kwargs):
        password = request.data.get('password')
        article_id = request.data.get('article')
        instance = self.get_object()
        if password == instance.password:
            self.perform_destroy(instance)
            return Response(status=status.HTTP_204_NO_CONTENT)
        return Response(status=status.HTTP_304_NOT_MODIFIED)

And request with password parameter, it was deleted successfully.

[delete.py]

import requests

r = requests.delete("http://mysite/article/45/")

[views.py]

class articleViewSet(viewsets.ModelViewSet):
    queryset = article.objects.all()
    serializer_class = articleSerializer

    def delete(self, pk, request):
        method = self.request.method
        article = article.objects.get(pk=pk)
        if method == 'DELETE':
            if request.password == article.password:
                article.delete()
                return Response(status=status.HTTP_200_OK)
        return Response(status=status.HTTP_304_NOT_MODIFIED)

I want to add some condition when DELETE data.

Here is my models.py and serializers.py

[serializers.py]

class articleSerializer(serializers.ModelSerializer):
    userkey = serializers.CharField(write_only=True)
    password = serializers.CharField(write_only=True)
    class Meta:
        model = article
        fields = ('articleNo', 'content', 'date', 'userkey', 'password')

[models.py]

class article(models.Model):
    articleNo = models.AutoField(primary_key=True)
    userkey = models.CharField(max_length=50, null=False)
    content = models.CharField(max_length=500, null=False)
    password = models.CharField(max_length=20, null=False, default='1234')
    date = models.DateTimeField(auto_now_add=True)

For example, below data is in database.

| articleNo | content           | date                       | userkey |password|
---------------------------------------------------------------------------------
|        33 | test article      | 2018-03-11 05:00:15.428661 | a1b2c3d4 | 1234  |

When "DELETE" method request, I want to compare request's password and article's password. If it is same, data will be deleted.

Refer to document, I think I have to override def delete().

But I don't know exactly what should I do.

How can I solve this issue?

Thanks.

Add your VIEW code as well.

Anup Yadav
– Anup Yadav

2018-03-13 09:51:28 +00:00
Commented Mar 13, 2018 at 9:51 — Anup Yadav
– Anup Yadav, Commented Mar 13, 2018 at 9:51
what view are you using? ModelViewset? APIView?

Shift 'n Tab
– Shift 'n Tab

2018-03-13 09:57:08 +00:00
Commented Mar 13, 2018 at 9:57 — Shift 'n Tab
– Shift 'n Tab, Commented Mar 13, 2018 at 9:57
can you add your views.py as well please?

Adam J
– Adam J

2018-03-13 10:10:18 +00:00
Commented Mar 13, 2018 at 10:10 — Adam J
– Adam J, Commented Mar 13, 2018 at 10:10
I added my views.py

Hide
– Hide

2018-03-13 10:36:21 +00:00
Commented Mar 13, 2018 at 10:36 — Hide
– Hide, Commented Mar 13, 2018 at 10:36

JPG · Accepted Answer · 2018-03-13 13:39:51Z

2

Assuming you have a delete payload as below,

request_payload = {
    "password": "request's password",
    "article": some_integer_value_article_instance,
    # other data
}

and your views be like

class articleViewSet(viewsets.ModelViewSet):
    queryset = article.objects.all()
    serializer_class = articleSerializer

    def delete(self, pk, request):
        password = request.data.get('password')
        article_id = request.data.get('article')
        article_instance = article.objects.get(id=article_id)
        if password == article_instance.password:
            article_instance.delete()
            return Response(status=status.HTTP_200_OK)
        return Response(status=status.HTTP_304_NOT_MODIFIED)

answered Mar 13, 2018 at 13:39

JPG

89.4k24 gold badges164 silver badges235 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

Hide Over a year ago

I modified views.py as your comment, and construct payload like you. But when I request payload except password, It deleted well. All I want is request.password == article.password, then deleted article. I added python request on my post

JPG Over a year ago

What you mean by request.password ? I couldn't understand

Hide Over a year ago

request.password is Request by user(HTTP Request) and article.password is password that stored in database. So, Requested password and stored password is same, article will be deleted. That is my scenario.

JPG Over a year ago

So, whats the output/error you have got after applying my answer ?

Hide Over a year ago

There is no error. Just deleted. (without password parameter, only article number parameter)

|

Hide · Accepted Answer · 2018-03-13 17:41:22Z

0

I just solved like this

class articleViewSet(viewsets.ModelViewSet):
    queryset = article.objects.all()
    serializer_class = articleSerializer

    def destroy(self, request, *args, **kwargs):
        password = request.data.get('password')
        article_id = request.data.get('article')
        instance = self.get_object()
        if password == instance.password:
            self.perform_destroy(instance)
            return Response(status=status.HTTP_204_NO_CONTENT)
        return Response(status=status.HTTP_304_NOT_MODIFIED)

And request with password parameter, it was deleted successfully.

answered Mar 13, 2018 at 17:41

Hide

3,3679 gold badges47 silver badges86 bronze badges

Comments

Chintan Joshi · Accepted Answer · 2018-03-13 09:55:35Z

-1

In your views.py file you can put up a condition which acts if the method is delete.

if request.method == 'DELETE':
    #your code here

answered Mar 13, 2018 at 9:55

Chintan Joshi

1491 silver badge14 bronze badges

Collectives™ on Stack Overflow

Django Rest framework conditional delete

3 Answers 3

9 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

9 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related