java 8 local variable in stream.foreach [duplicate]

Question

I would like to use local variables in lambda functions but I get error: Please see the 1. and 2. points in the code.

class Foo {
    int d = 0; // 1. It compiles, but ugly, 2. doesnt compile
    public void findMax(List<List<Route>> routeLists) {
        int d = 0; // 2.Error : Local variable dd defined in an enclosing scope must be final or effectively final
        routeLists.forEach(e-> {
            e.forEach(ee -> {
                d+=ee.getDistance();    
            });

        });
        ... doing some other operation with d
    }
}

How can I use them whitout setting them as global variables ?

multiple declaration is not allowed, d must be final and can not be changed inside of forEach — devops
– devops, Commented Mar 14, 2018 at 8:52
Recently answered: stackoverflow.com/a/49249463/6099347 The same fundamentals apply even on lambdas — Aniket Sahrawat
– Aniket Sahrawat, Commented Mar 14, 2018 at 9:08

Andy Turner · Accepted Answer · 2018-03-14 17:11:30Z

8

forEach is the wrong tool for the job.

int d =
    routeLists.stream()                // Makes a Stream<List<Route>>
        .flatMap(Collection::stream)   // Makes a Stream<Route>
        .mapToInt(Route::getDistance)  // Makes an IntStream of distances
        .sum();

Or just use nested for loops:

int d = 0;
for (List<Route> rs : routeLists) {
  for (Route r : rs) {
    d += r.getDistance();
  }
}

edited Mar 14, 2018 at 17:11

answered Mar 14, 2018 at 9:05

Andy Turner

141k11 gold badges169 silver badges263 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Niraj Sonawane Over a year ago

1+, you might need to add routeLists.Strem()

Andy Turner Over a year ago

@Niraj yes. I wasn't paying particular attention to the types; actually, a flatMap is needed too. Thanks for highlighting.

Andy Turner Over a year ago

@Eugene fixed..

Davide Lorenzo MARINO · Accepted Answer · 2018-03-14 09:03:32Z

2

You can't use an int as variable because it must be final to be used in a stream.

But You can create a class wrapping the int.

Then declare the variable holding this class as final.

Changing the content of the inner int variable.

public void findMax(List<List<Route>> routeLists) {
        final IntWrapper dWrapper = new IntWrapper();
        routeLists.forEach(e-> {
            e.forEach(ee -> {
                dWrapper.value += ee.getDistance();    
            });

        });

        int d = dWrapper.value;

        ... doing some other operation with d
    }

 public class IntWrapper {
    public int value;
 }

answered Mar 14, 2018 at 9:03

Davide Lorenzo MARINO

27k4 gold badges45 silver badges58 bronze badges

1 Comment

Csaba Prog Over a year ago

Thanks for everyone, mostly for you.

glglgl · Accepted Answer · 2018-03-14 11:03:03Z

Having side effects is discouraged (or even forbidden?) in the functions used in a stream.

A better way would be one of

routeLists.stream()
    .flatMapToInt(innerList -> innerList.stream()
        .mapToInt(Route::getDistance))
    .sum()

or

routeLists.stream()
    .mapToInt(innerList -> innerList.stream()
        .mapToInt(Route::getDistance).sum())
    .sum()

The first will, for each sublist, create a stream of distances. All these streams will become flattened and summed at once.

The second will create the sum of each sublist and then add all those sums together again.

They should be equivalent, but I am not sure if the one or other is better in terms of performance (i. e., if flattening the streams is more expensive than summing).

A third alternative of flattening the lists and then getting and summing the distances is covered by Andy Turner's answer.

Collectives™ on Stack Overflow

java 8 local variable in stream.foreach [duplicate]

3 Answers 3

3 Comments

1 Comment

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

1 Comment

Comments

Linked

Related