return false or true while iterating an array of object [duplicate]

Question

I would like find() function to return true when it finds 'john' and stop iterating trough array. Or return false if looking for name, let's say maria, which is not in any of our objects. What am I not understanding that I can't achieve what I need in this code? Thanks.

var array = [
    {name:'paul',age:20},
    {name:'john',age:30},
    {name:'albert',age:40}
];

var find = function(arr){
    arr.forEach(function(i){
        if(i.name === 'john'){
            console.log('found him');
            return true;
        } else {
            console.log('not there');
            return false;
        }
    });
};
find(array);

I have seen some similar questions here but I could not get or understand answer for my question. Explicitly I need the function to be able return the name value and at the same time return true or false.

btw, you need no semicolon after a block statement { /* ... */ }. — Nina Scholz
– Nina Scholz, Commented Mar 16, 2018 at 16:47

Nina Scholz · Accepted Answer · 2018-03-16 16:57:48Z

9

You could use Array#some which stops iterating if a truthy value is returned inside of the callback.

var array = [{ name: 'paul', age:20 }, { name: 'john', age:30 }, { name: 'albert', age:40 }],
    find = function(array, name) {
        return array.some(function(object) {
            return object.name === name;
        });
    };

console.log(find(array, 'paul'));  // true
console.log(find(array, 'maria')); // false

edited Mar 16, 2018 at 16:57

answered Mar 16, 2018 at 16:46

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Tukadas Over a year ago

Thanks I think this is exactly what I was looking for. works perfect for me.

Kevin Qian · Accepted Answer · 2018-03-16 16:46:11Z

1

You are returning in the forEach(function(i) {}), which is only returning in the inside function function(i) {}, that does not help return from the outer function find(). Also, your logic with return false; seems also problematic. Simply use normal for loops would be fine.

var array = [
    {name:'paul',age:20},
    {name:'john',age:30},
    {name:'albert',age:40}
];

var find = function(arr, name) {
  for (let i of arr) {
    if(i.name === name){
      console.log('found ' + name);
      return true;
    }
  }
  console.log(name + ' not there');
  return false;
};

find(array, 'paul');
find(array, 'maria');

answered Mar 16, 2018 at 16:46

Kevin Qian

2,7201 gold badge18 silver badges30 bronze badges

2 Comments

baeyun Over a year ago

Using the for..of loop with arrays isn't ideal performance-wise. Check stackoverflow.com/questions/13645890/…

Kevin Qian Over a year ago

@bukharim96 Yeah I did not intend to make it of high performance, simply trying to point out the problem of the original code block

baeyun · Accepted Answer · 2018-03-16 16:51:12Z

0

Stop using the forEach method and try this instead:

var array = [
    {name:'paul',age:20},
    {name:'john',age:30},
    {name:'albert',age:40}
];

var find = function(arr){
	var returnValue = false;
    
    for (var i = 0; i <= arr.length; i++) {
      if(arr[i].name === 'john') {
      	ret = true;
      	break;
      }
    }

    return returnValue;
};
find(array);

answered Mar 16, 2018 at 16:51

baeyun

2281 silver badge6 bronze badges

Collectives™ on Stack Overflow

return false or true while iterating an array of object [duplicate]

3 Answers 3

1 Comment

2 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

Comments

Linked

Related