Cannot read property 'save' of undefined Angular

Question

the server written in Node.js returns the following error message:

TypeError: Cannot read property 'save' of undefined
    at e:\_Angular5\administration\routes\product.js:34:12
    at e:\_Angular5\administration\node_modules\mongoose\lib\model.js:3930:16
    at (anonymous function).call (e:\_Angular5\administration\node_modules\mongoose\lib\query.js:3018:9)
    at model.Query.Query._findOne (e:\_Angular5\administration\node_modules\mongoose\lib\query.js:1497:12)
    at model.Query.Query.findOne (e:\_Angular5\administration\node_modules\mongoose\lib\query.js:1611:8)

my server code server.js:

const express = require('express');

const bodyParser = require('body-parser');
const path = require('path');
const http = require('http');
const app  = express();

var user = require('./routes/user.js');
var product = require('./routes/product.js');
const api = require('./server/api');

app.use(bodyParser.json());
app.use(bodyParser.urlencoded({ extended: false}));

app.use(function(req, res, next) {
  res.setHeader("Access-Control-Allow-Origin", "*");
  res.setHeader('Access-Control-Allow-Methods', 'PUT, GET, POST, DELETE, OPTIONS');
  res.setHeader("Access-Control-Allow-Headers", "Origin, X-Requested-With, Content-Type, Accept, Authorization, Access-Control-Allow-Credentials");
  res.setHeader("Access-Control-Allow-Credentials", "true");
  next();
});

app.use(express.static(path.join(__dirname, 'dist')));

app.post('/register', user.signup);
app.post('/login', user.login); 
app.get('/user/:id', user.getuserDetails);

app.put('/user/:id', user.updateUser);
app.post('/user/products/:id', product.saveproduct);  // did not work

app.get('*', (req, res) => {
  res.sendFile(path.join(__dirname, 'dist/index.html'));
});



const port = process.env.PORT || '4200';
app.set('port', port);

const server = http.createServer(app);

server.listen(port, () => console.log(`Running on localhost:${port}`));

routes/product.js:

var mongoose = require( 'mongoose' );
var Product = require('../models/products');
var config = require('../server/config');

exports.saveproduct = function(req, res, next){

    const userid = req.params.id;
    const product_name = req.body.product_name;   
    const product_type = req.body.product_type;
    const product_desc = req.body.product_desc;
    const expid = req.body.expid;

    if (!userid || !product_name || !product_type || !product_desc) {
        return res.status(422).send({ success: false, message: 'Posted data is not correct or incompleted.' });
    } else {

    if (userid) {   
        Product.findById({product_name: req.body.product_name} ).exec(function(err, product){

            if(err){ res.status(400).json({ success: false, message: 'Error processing request '+ err }); }

            if(product) {
                product.product_name = product_name;
                product.product_type = product_type;
                product.product_desc = product_desc;
      }     
            product.save(function(err) { 

                if(err){ res.status(400).json({ success: false, message: 'Error processing request '+ err }); }
                res.status(201).json({
                    success: true,
                    message: 'product updated successfully'
                });
            });
        });

    }else{
        let oProduct = new Product({
            userid: uid,
            product_name: product_name,
            product_type: product_type,
            product_desc: product_desc

        });

        oProduct.save(function(err) { // error 
            if(err){ res.status(400).json({ success: false, message: 'Error processing request '+ err }); }

            res.status(201).json({
                success: true,
                message: 'Product saved successfully'
            });
        });

    }
    }
}

src/app/product/user-products.component.ts

    @Component({
      selector: 'app-user-products',
      templateUrl: './user-products.component.html',
      styleUrls: ['./user-products.component.css']
    })
    export class UserProductsComponent implements OnInit {

      user: User;
      UserType = UserType;

      product_name: string;
      product_type: ProductType;
      ProductType = ProductType;
      product_desc: string;

      produktForm: FormGroup;
      products: Product;
      userObj: any;

      productid: string;
      constructor(private fb: FormBuilder,
        private route: ActivatedRoute,
        private router: Router,
        private productsService: ProductsService,
        private authService: AuthService) { }


      ngOnInit() {
        this.userObj = this.authService.currentUser;

        this.route.params.subscribe((params: any) => {
          if (params.id) {
            console.log('params.id : ');
            console.log(params.id);
            this.productid = params['_id'];
            console.log('this.productid : ');
            console.log(this.productid);
          }
        });

        this.produktForm = this.fb.group({
          product_name: ['', Validators.required],
          product_type: ['', Validators.required],
          product_desc: ['', Validators.required]
        });

      }


      saveProduct(produktForm: any) {

        if (this.produktForm.dirty && this.produktForm.valid) {
          const theForm = this.produktForm.value;
          if (this.productid !== '') {
            produktForm.productid = this.productid;
          }

          this.productsService.add_product(this.userObj.userid, theForm)
            .subscribe(data => {
              if (data.success === false) {
                if (data.errcode) {
                  this.authService.logout();
                  this.router.navigate(['login']);
                }
                console.log('Error ' + data.message);

              } else {
                console.log('Success ' + data.message);

              }
              // if (!this.productid) {
              this.produktForm.reset();
              // }
            });
        }
      }
    }

I do not know why the save method does not work. How to correct a mistake? data sent from the form are as follows:

{product_name: "d", product_type: "1", product_desc: "d", productid: undefined}

At some point, you check if(product){ do some stuff } and then right after that (where product is possibly undefined) you call product.save(), so... makes sense. — Jeremy Thille
– Jeremy Thille, Commented Mar 23, 2018 at 13:12

Narendra Jadhav · Accepted Answer · 2018-03-23 13:15:33Z

1

 if (err) {
     res.status(400).json({
         success: false,
         message: 'Error processing request ' + err
     });
 }

 if (product) {
     product.product_name = product_name;
     product.product_type = product_type;
     product.product_desc = product_desc;
 }
 product.save(function(err) {

     if (err) {
         res.status(400).json({
             success: false,
             message: 'Error processing request ' + err
         });
     }
     res.status(201).json({
         success: true,
         message: 'product updated successfully'
     });
 });

The error you are getting is because your product object is undefined. You are checking whether your object exists and assigning properties, but you are not checking whether your object exists when trying to call product.save().

Try nesting product.save() inside of if(product){ }

edited Mar 23, 2018 at 13:15

Narendra Jadhav

10.3k15 gold badges35 silver badges45 bronze badges

answered Mar 23, 2018 at 13:12

Jacob Scheib

357 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user2129896 · Accepted Answer · 2018-03-23 13:52:18Z

works, the solution below:

var mongoose = require( 'mongoose' );
var Product = require('../models/products');
var config = require('../server/config');

exports.saveproduct = function(req, res, next){


    const userid = req.params.id;
    const product_name = req.body.product_name;  
    const product_type = req.body.product_type;
    const product_desc = req.body.product_desc;
    const expid = req.body.expid;

    if (!userid || !product_name || !product_type || !product_desc) {
        return res.status(422).send({ success: false, message: 'Posted data is not correct or incompleted.' });
    } else {

    if (expid) {        
        Product.findById({product_name: req.body.product_name} ).exec(function(err, product){
            if(err){
        res.status(400).json({ success: false, message: 'Error processing request '+ err });
      }
            if(product) {
                product.product_name = product_name;
                product.product_type = product_type;
                product.product_desc = product_desc;
      }
            product.save(function(err) {
                if(err){ res.status(400).json({ success: false, message: 'Error processing request '+ err }); }
                res.status(201).json({
                    success: true,
                    message: 'product updated successfully'
                });
            });
        });

    }else{

        let oProduct = new Product({
            userid: userid,
            product_name: product_name,
            product_type: product_type,
            product_desc: product_desc
        });
        oProduct.save(function(err) {
            if(err){ res.status(400).json({ success: false, message: 'Error processing request '+ err }); }

            res.status(201).json({
                success: true,
                message: 'Product saved successfully'
            });
        });
    console.log( 'Product saved successfully');
    }
    }
}

Collectives™ on Stack Overflow

Cannot read property 'save' of undefined Angular

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related