Array manipulation with splice

Question

i have this array two functions one adds to it the other one takes away from it or at least thats the plan. can someone look at my code and see whats wrong with my second function. splice is taking my last element on array but not the specific one that am trying to get. please

var shoppingCart = [];
function AddtoCart(name, description, price) {
  // JavaScript Object that  holds three properties :    Name,Description and Price
  var singleProduct = {};
  //Fill the product object with data
  singleProduct.Name = name;
  singleProduct.Description = description;
  singleProduct.Price = price;
  //Add newly created product to our shopping cart 
  shoppingCart.push(singleProduct);
  //call display function to show on screen

}

function removefromCart(name, description, price) {
  // JavaScript Object that will hold three properties :    Name,Description and Price
  var singleProduct = {};
  //Fill the product object with data
  singleProduct.Name = name;
  singleProduct.Description = description;
  singleProduct.Price = price;
  var index = shoppingCart.indexOf(singleProduct);
  shoppingCart.splice(index, 1);
}

CertainPerformance · Accepted Answer · 2018-04-05 04:27:47Z

3

Inside removefromCart, singleProduct is a newly created object, so it definitely won't exist in shoppingCart, even if it has the same properties - variables of nonprimitives (such as objects) essentially point to memory locations, so if you create a new object, the variable pointing to that object has a new memory location that nothing else in your script knows about, so anyArr.indexOf(newObject) will always return -1.

Use .findIndex instead:

function removefromCart(name, description, price) {
  const index = shoppingCart.findIndex(({ Name, Description, Price }) => (
    name === Name &&
    description === Description &&
    price === Price
  ));
  if (index === -1) {
    console.log('No matching product found!');
    return;
  }
  shoppingCart.splice(index, 1);
}

answered Apr 5, 2018 at 4:27

CertainPerformance

373k55 gold badges354 silver badges359 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Deepak Sharma Over a year ago

just a thought @joel keep in mind suggested solution use ES6 notation so you might face some issue with older browser or like IE. you can ofcourse use function(){ .. .. } instead of delegate if required.

CertainPerformance Over a year ago

Always write in ES6+ for convenience and code readability's sake - if you need to support IE11 and other ancient browsers, use Babel, that's exactly what it's for.

Collectives™ on Stack Overflow

Array manipulation with splice

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related