NodeJs express.Router resolves to wrong path

Question

I have a router setup like below:

'use strict';

const express = require('express');
const controller = require('../../module/controllers/controller');

const router = express.Router();

router.get('/:param', controller.getEntity);
router.get('/', controller.getEntities);
router.put('/:param', controller.updateEntity);
router.post('/update/:param', controller.updateEntity);
router.get('/subpath', controller.getEntityPath);

module.exports = router;

All the above routes have a parent route: parent

When I try to call http://hostname/parent/subpath it keeps going to http://hostname/parent/. Only when I comment out the below lines, subpath becomes available:

'use strict';

const express = require('express');
const controller = require('../../module/controllers/controller');

const router = express.Router();

// router.get('/:param', controller.getEntity);
// router.get('/', controller.getEntities);
router.put('/:param', controller.updateEntity);
router.post('/update/:param', controller.updateEntity);
router.get('/subpath', controller.getEntityPath);

module.exports = router;

What am I doing wrong in the configuration?

Hamza Fatmi · Accepted Answer · 2018-04-09 09:29:03Z

8

You need to reverse the order of the routes :

'use strict';

const express = require('express');
const controller = require('../../module/controllers/controller');

const router = express.Router();

router.get('/', controller.getEntities);
router.post('/update/:param', controller.updateEntity);
router.get('/subpath', controller.getEntityPath);
router.get('/:param', controller.getEntity);
router.put('/:param', controller.updateEntity);
module.exports = router;

Because http://hostname/parent/subpath matches /:param first.

answered Apr 9, 2018 at 9:29

Hamza Fatmi

1,2559 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nicolas Takashi · Accepted Answer · 2018-04-09 08:49:10Z

0

Try to put absolute routes above the relative routes.

router.post('/update/:param', controller.updateEntity);
router.get('/subpath', controller.getEntityPath);    
router.put('/:param', controller.updateEntity);

answered Apr 9, 2018 at 8:49

Nicolas Takashi

1,7802 gold badges11 silver badges11 bronze badges

Collectives™ on Stack Overflow

NodeJs express.Router resolves to wrong path

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related