setState error for onclick in react

Question

I'm get this error Warning: setState(...): Cannot update during an existing state transition (such as within render or another component's constructor). Render methods should be a pure function of props and state; constructor side-effects are an anti-pattern, but can be moved to componentWillMount for

<a key={brand} onClick={this.someFn(Brands[brand])}>

James · Accepted Answer · 2018-04-15 00:32:56Z

1

I strongly advise against mutating the state inside render() methods. In fact it is strongly suggested by the maintainers of React, to keep the render() method as a pure function.

If you want to change the state between different components, for example if you have a sidebar, the most robust solution is to use Redux or an equivalent application state library.

answered Apr 15, 2018 at 0:32

James

3,82512 gold badges45 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

sonia maklouf Over a year ago

I can't use redux or another state library. I think I'll use function to pass icon from the child component to the parent component without any state modification

Omar K · Accepted Answer · 2018-04-14 23:56:17Z

0

 <a key={brand} onClick={() => this.someFn(Brands[brand])}>

call it with an arrow function

answered Apr 14, 2018 at 23:56

Omar K

3,4213 gold badges25 silver badges41 bronze badges

Collectives™ on Stack Overflow

setState error for onclick in react

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related