CodeIgniter 3 MySQL - verifying users password is not working

Question

The following function is not returning true and I do not understand why. I'm not getting any database errors, but it definitely returns false for some reason. The table and field names are 100% correct.

public function verify_password($username, $password){
    $this->db->select('password');
    $this->db->from('user_account');
    $this->db->where('username', $username);
    $query = $this->db->get();

    if($query == $password){
      return true;
    } else {
      return false;
    }
  }

Don't store plain text passwords. Instead use password_hash() and password_verify(). — Alex Howansky
– Alex Howansky, Commented Apr 19, 2018 at 19:29

DFriend · Accepted Answer · 2018-11-02 15:56:09Z

4

The problem is that you need to get some results from your query. Read about Generating Query Results.

Revised method as follows

public function verify_password($username, $password)
{
    //use method chaining, it's more efficient and less typing
    $query = $this->db
        ->select('password')
        ->from('user_account')
        ->where('username', $username)
        ->get();

    //were any matching rows found?
    if($query->num_rows() > 0)
    {
        // get first row of data and check 'password' value against passed value
        // return is a boolean
        return $query->row()->password === $password;
    }

    //There are no rows that match so clearly not logged in
    return false;
}

As the comments in your question point out you should not store plain text passwords.

edited Nov 2, 2018 at 15:56

answered Apr 19, 2018 at 19:45

DFriend

8,9741 gold badge16 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user4419336 Over a year ago

I think he is storing plain passwords.

Chris Over a year ago

It was the way that I was trying to access the query result to compare with the password that was the issue. And yes I understand they should not be stored as plaintext, I will get round to that eventually. Thanks!

Collectives™ on Stack Overflow

CodeIgniter 3 MySQL - verifying users password is not working

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related