Dynamically adding Context Menu items

Question

For some reason, regardless of how many times the toolstripmenuitem is added to the context menu, it always says the context menu does not contain the item.

ToolStripMenuItem Colour = new ToolStripMenuItem("Colour");

ctmFile.Show(Cursor.Position);
Selecteditem = lvFiles.FocusedItem.Text.ToString();
if (lvFiles.FocusedItem.ImageKey.ToString() == "Folder")
{

    if (ctmFile.Items.Contains(Colour) == false)
    {
        ctmFile.Items.Add(Colour);
    }

}
else
{
    if(ctmFile.Items.Contains(Colour))
    {
        ctmFile.Items.Remove(Colour);
    }
}

If the answer below helped you fix it, mark it as the chosen answer. If you found your own solution could you post your own answer. — user9401448
– user9401448, Commented Apr 20, 2018 at 14:12

JuanR · Accepted Answer · 2018-04-20 14:42:17Z

2

Just to add on top of Ed's answer, I would recommend using keys instead:

ctmFile.Show(Cursor.Position);
Selecteditem = lvFiles.FocusedItem.Text.ToString();
if (lvFiles.FocusedItem.ImageKey.ToString() == "Folder")
{

    if (!ctmFile.Items.ContainsKey("Colour")) 
    {
        ToolStripMenuItem Colour = new ToolStripMenuItem("Colour");
        Colour.Name= "Colour"; //Add a name (key) to your menu.
        ctmFile.Items.Add(Colour);
    }

}
else
{
    if (ctmFile.Items.ContainsKey("Colour")) 
    {
        ctmFile.Items.RemoveByKey("Colour");
    }
}

edited Apr 20, 2018 at 14:42

answered Apr 20, 2018 at 14:20

JuanR

7,8911 gold badge23 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

15ee8f99-57ff-4f92-890c-b56153 Over a year ago

I like this better than mine because it finds the menu item using a framework-appropriate feature.

JuanR Over a year ago

Thank you, @EdPlunkett. You solved the problem though :-) (new instance every time).

15ee8f99-57ff-4f92-890c-b56153 · Accepted Answer · 2018-04-20 14:20:30Z

You are creating a new menu item and searching for that. But since it was just created, it obviously can't already be in the menu. That's why you never find it there. A different menu item with that text may have been added before, but your code is not looking for that one.

You need to search the menu items for an item that has that text. The code can be simplified a bit in other ways:

var colorItemText = "Colour";
var colorMenuItem = ctmFile.Items.Cast<ToolStripMenuItem>()
                      .FirstOrDefault(mi => mi.Text == colorItemText);

if (lvFiles.FocusedItem.ImageKey.ToString() == "Folder")
{
    //  Create and add if not already present
    if (colorMenuItem == null)
    {
        colorMenuItem = new ToolStripMenuItem(colorItemText);
        ctmFile.Items.Add(colorMenuItem);
    }
}
else if (colorMenuItem != null)
{
    //  Remove if already present. 
    ctmFile.Items.Remove(colorMenuItem);
}

Collectives™ on Stack Overflow

Dynamically adding Context Menu items

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related