Saving uploaded image file in public dir not working in laravel 5.6

Question

I have created a designated location to store all the uploaded images in public dir like this:

and I have the default config/filesystem.php for public driver like this:

    'public' => [
        'driver' => 'local',
        'root' => storage_path('app/public'),
        'url' => env('APP_URL').'/storage',
        'visibility' => 'public',
    ],

Within my repository, I am trying to save the uploaded image like this:

    // ... snipped        

    if (array_key_exists('logo', $validated)) {
        $logoPath = $validated['logo']->store(
            'uploads/logos',
            'public'
        );
        $company->logo = url($logoPath);
    }

    $company->save();

In the database, I can see the value of logo field for the company record like this: http://my-app.local/uploads/logos/3hlsAhnnIPjd4zhdpfhvKw4tqDkpcCz23NczwhVM.png

However, the public/uploads/logos dir is empty. Any idea what might be wrong here? Am I supposed to use the ->move() method on the UploadedFile instead of ->store()?

Is it maybe in the storage folder (storage/app/public by any chance)? — DevK
– DevK, Commented Apr 22, 2018 at 0:23
ah! you're right 'root' => storage_path('app/public'), I think i need to update this path. Let me check. — Latheesan
– Latheesan, Commented Apr 22, 2018 at 0:24
Yup, it's been a minute since I worked with file upload. But storage_path() helper will generate the path to the storage folder. You probably just want to change that to something like public_path('uploads'). Or create a symlink from storage folder to public folder — DevK
– DevK, Commented Apr 22, 2018 at 0:26
Yea, this was the problem, i didn't pay enough attention to the filesystem definition. Silly mistake. — Latheesan
– Latheesan, Commented Apr 22, 2018 at 0:31

aj3sh · Accepted Answer · 2018-04-22 03:00:19Z

1

You can use an alternative method for uploading images in your public directory.

$request->validate([
    'logo' => 'image|required',
]);

if($request->hasFile('logo')){
   $company->logo = $request->image->move('uploads/logo', $request->logo->hashName());
}
$company->save()

answered Apr 22, 2018 at 3:00

aj3sh

3843 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Giedrius Kiršys · Accepted Answer · 2018-04-22 17:36:41Z

0

Actually, yes, it was your mistake, but not the one you just found. By default laravel local storage points to storage/app/public directory, because laravel wants you to act professionally and store all uploaded files in storage, not in some kind of public directory. But then you would ask - how on earth user should access non-public storage directly? And there is a caught - php artisan storage:link command. It creates symbolic link from public directory to storage directory (storage/app/public -> public/storage). This is mostly because of deployments and version management.

answered Apr 22, 2018 at 17:36

Giedrius Kiršys

5,3642 gold badges22 silver badges28 bronze badges

Collectives™ on Stack Overflow

Saving uploaded image file in public dir not working in laravel 5.6

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related