Jquery replace not working for inner strings

Question

I need to replace ||| from all the input fields using jquery. But it is only replacing the first item. I need to use regex but I don't know how to add that to the string.

$(document).ready(function() {
    $("#layerPaper").children("div").each(function() {
        $val = $(this).children('input:text');
        $val.val($val.val().replace('|||', '\"'));
    });
});

Thanks.

There are some different valid interpretations of your question. What do you mean by "it is only replacing the first item"? Do you mean that each input may have more than one |||? Or does it refer to the fact that in each <div> element you're only using the value of the first <input> element.? — user113716
– user113716, Commented Feb 14, 2011 at 23:38

user229044 · Accepted Answer · 2012-07-31 15:57:25Z

4

If you mean there are multiple instances of '|||' in an element then the replace you want is:

replace(/\|\|\|/g, '\"'));

edited Jul 31, 2012 at 15:57

user229044♦

241k41 gold badges348 silver badges350 bronze badges

answered Feb 14, 2011 at 23:32

Neil

3,2111 gold badge19 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Brad Christie Over a year ago

/\|{3}/g, too. (Same number of characters, but arguably more legible. ;-)

Neil Over a year ago

@Brad, you're right of course, for only a few characters I prefer to show each one, but if there are say more than 5, or if, like here, the character has to be escaped, the "{n}" format is more legible.

user113716 · Accepted Answer · 2011-02-14 23:28:17Z

3

$("#layerPaper > div > input:text").val(function(i,val){ 
    return val.replace('|||', '\"');
});

answered Feb 14, 2011 at 23:28

user113716

323k64 gold badges454 silver badges441 bronze badges

5 Comments

user113716 Over a year ago

Thanks @Brad. jQuery sure has some nice tricks for shortening code.

dotnetrocks Over a year ago

The code was replacing the ||| with the string function(i,val){ return val.replace('|||', '\"'); Please let me know what is wrong

user113716 Over a year ago

@dotnetrocks: That's very strange. What version of jQuery are you using? To pass a function, you'll need jQuery 1.4 or later.

dotnetrocks Over a year ago

I am using the older version ver 1.3.Thanks for correcting that.I will try it using the latest ver.

user113716 Over a year ago

@dotnetrocks: You're welcome. I think I misunderstood your question initially. I didn't realize you potentially had more than one ||| in an <input> element. The regex solution @Neil gave (or the comment from Brad below his answer) is the way to go.

Brad Christie · Accepted Answer · 2011-02-14 23:27:36Z

0

You don't need regex, I think your problem lies in the following:

$val.val($val.val().replace('|||', '\"'));

The .val() function only works on the first element found. You can switch this by using $.each though, fairly simply:

$(this).children('input:text').each(function(i,e){
  $(e).val($(e).val().replace('|||','"'));
});

answered Feb 14, 2011 at 23:27

Brad Christie

102k16 gold badges160 silver badges200 bronze badges

2 Comments

lonesomeday Over a year ago

Using a function callback would be even nicer.

Brad Christie Over a year ago

@lonesomeday: I agree, but just want showing where the error was and how to solve. Wasn't going too deeply in to refactoring. Besides, @patrickdw did so for me. ;-)

Collectives™ on Stack Overflow

Jquery replace not working for inner strings

3 Answers 3

2 Comments

5 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

5 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related