Laravel 5.5 controller update function issue

Question

I have the update function in the controller where I want to store the values of a form. Here is the code;

public function update(Request $request, $id=1){
        $data = array(); 

        $data->firstName = $request->get('firstName');
        $data->lastName  = $request->get('lastName');
        $data->email     = $request->get('email');
        $data->company   = $request->get('company');
        $data->website   = $request->get('website');
        UserAdmin::where('id', Auth::user()->id)->update($data);

        //return view('Administrator.profile.profile',$data);
        return redirect('administrator/myprofile');
    }

However, after submitting the form, it show me the error;

Attempt to assign property of non-object

$data is array not object

M Khalid Junaid
– M Khalid Junaid

2018-05-09 10:43:20 +00:00
Commented May 9, 2018 at 10:43 — M Khalid Junaid
– M Khalid Junaid, Commented May 9, 2018 at 10:43

Loek · Accepted Answer · 2018-05-09 10:44:16Z

3

That's because you can't assign array values with $data->key. An array is not an object and as such has a different syntax.

This wil work however:

public function update(Request $request, $id=1){
    $data = array(); 

    $data['firstName'] = $request->get('firstName');
    $data['lastName'] = $request->get('lastName');

    // etc
}

answered May 9, 2018 at 10:44

Loek

4,15323 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

zedling · Accepted Answer · 2018-05-09 11:04:51Z

1

You are trying to use an object operator (->) on an array.

For what you are trying to achieve it would be best to use the model to your advantage. By using findOrFail() you can return an object.

public function update(Request $request, $id=1){

    $data = UserAdmin::findOrFail(Auth::id());
    $data->firstName = $request->get('firstName');
    $data->lastName  = $request->get('lastName');
    $data->email     = $request->get('email');
    $data->company   = $request->get('company');
    $data->website   = $request->get('website');
    $data->save();

    //return view('Administrator.profile.profile',$data);
    return redirect('administrator/myprofile');
}

This would achieve what you want but is cleaner. Look at the Laravel Eloquent Documentation here.

edited May 9, 2018 at 11:04

zedling

6378 silver badges29 bronze badges

answered May 9, 2018 at 10:49

Kyle Wardle

8306 silver badges23 bronze badges

Collectives™ on Stack Overflow

Laravel 5.5 controller update function issue

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related