Passing variables in onclick event

Question

I have the following span element defined in the view in the MVC app

<span id="openDocument" 
      class="fa fa-sign-in" 
      style="cursor:pointer; 
      color:#5d9cec" 
      data-toggle="tooltip" 
      onclick="openDocument(@item.formattedReference.ToString())")>
</span>

Javascript function:

function openDocument(documentId) {
    debugger;
    window.open("https://somelongURL/documentId=" + documentId);
};

The problem that I am having with this code is that this code works for document id that has numbers (eg. 12345) but it doesn't work for alphanumeric numbers (eg. R12345).

It gives me an error saying: Uncaught Reference Error: R12345 is not defined.

How do i solve this problem?

Thanks in advance.

Michael W. Czechowski · Accepted Answer · 2018-05-17 14:16:49Z

3

Try to put your variable in quotes:

<span ... onclick="openDocument('@item.formattedReference.ToString()')"></span>

Unlike numbers, strings can only be passed in quotation marks.

Explanation:

Uncaught Reference Error: R12345 is not defined.

The error message contains all information about debugging, namely that the transmitted value is interpreted as a variable as soon as it contains letters. R12345 was interpreted as a variable.

edited May 17, 2018 at 14:16

answered May 17, 2018 at 14:11

Michael W. Czechowski

3,4452 gold badges26 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Fast Chip Over a year ago

thanks a lot for the insight. that was really helpful :)

user3559349 Over a year ago

Note you do not need the .ToString()

Collectives™ on Stack Overflow

Passing variables in onclick event

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related