Python While true, Try/Except, returning value

Question

When I try to return a value after making a variable and putting a while True, try/except commands, the variable doesn't return the value. I am trying to globalize this "starting" so that it can be used.

def start_time():
    while True:
        try:
            starting = int(input("Please enter a starting hour(HH): "))
            if starting < 0:
                print("There are no negative hours!")
            elif starting > 24:
                print("There are only 24 hours in a day!")
            else:
                break
        except ValueError:
            print("Please enter in a correct format (HH)")
    return starting
def end_time():
    while True:
        try:
            ending = int(input("Please enter an ending hour (HH): "))
            if ending < starting:
                print("You can only plan a day!")
            elif ending < 0:
                print("There are only 24 hours in a day!")
            elif ending > 24:
                print("There are only 24 hours in a day!")
            else:
                break
        except ValueError:
            print("Please enter in a correct format (HH)")
    return ending

#obtain starting and ending time
start_time()
end_time()

#confirm starting and ending time

Thanks

You never break out of the while loop when the input is correct. Replace pass with break (or just an early return there). — 9769953
– 9769953, Commented May 28, 2018 at 4:48

Paula Thomas · Accepted Answer · 2018-05-28 04:51:15Z

1

Right, one amendment is needed to achieve your stated aim:

replace:

start_time()

with

starting = start_time()

when a function is called that returns a value without an explicit place for that value to be put python in effect throws away the value.

answered May 28, 2018 at 4:51

Paula Thomas

1,1901 gold badge10 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Paula Thomas Over a year ago

One other thing: you'll need to change the pass to a break on the else branch of your if statement or, more efficiently, put the return statement there or you'll never get out of the infinite loop!

Austin · Accepted Answer · 2018-05-28 05:09:44Z

1

Instead of making starting global, return starting value to the caller. Use of global needs to be avoided if possible. Read why it is a bad design here. To implement in better way, your caller should be modified as:

starting = start_time()

Now starting time is obtained in starting.

Similarly,

ending = end_time()

Ending time is obtained in ending.

Also pass does not break out of the infinite while loop. It does nothing, but is used when a statement is required syntactically but the program requires no action. Use a break in-place of pass. It exits out of the innermost loop.

Read about the usage of break here.

answered May 28, 2018 at 5:09

Austin

26.1k4 gold badges28 silver badges52 bronze badges

Collectives™ on Stack Overflow

Python While true, Try/Except, returning value

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related