Google Apps Script - How to break loop to prevent error message

Question

I have the below script for archiving rows from one sheet to another if some conditions are met (column G is not blank, and the date in column A is equal or older than 3 months). it appends the matching row to a new sheet and deletes the row from the original sheet.

function Archiving() {

  var masterSS = SpreadsheetApp.getActiveSpreadsheet() || SpreadsheetApp.openById('sheetID');
  var responseSheet = masterSS.getSheetByName('responseSheetname');
  var archiveSheet = masterSS.getSheetByName('archiveSheetName');

  var responseData = responseSheet.getRange(2,1, responseSheet.getLastRow()-1, responseSheet.getLastColumn()).getValues();
  var lastRow = responseSheet.getLastRow();
  var today = new Date();
  for (var i = responseData.length-1; i < responseData.length; i--){
    var row = responseData[i];
    if (row[0] == "") {break;}
    if (row[6] != "") {
      var date = row[0];
      if (date != "" && ((today.getTime() - date.getTime()) > 7776000000)) {
        Logger.log(date)
        archiveSheet.appendRow(responseData[i]);
        responseSheet.deleteRow(i+2);
      }
    }
  }
}

It's working, however, when it has completed archiving, it throws out the following error:

TypeError: Cannot read property "0" from undefined. (line 42, file "Archiving Script")

I figure this because it's still trying to loop through and finding nothing, something I had hoped the break would fix, but it hasn't.

Anyone able to suggest a fix?

It seems that there is no end of the for loop of for (var i = responseData.length-1; i < responseData.length; i--){. So how about modifying from i < responseData.length to i >= 0? — Tanaike
– Tanaike, Commented May 30, 2018 at 11:42
Looks like @LGSon hit the nail on the head, that seems to have solved it. Thanks, folks! — SL8t7
– SL8t7, Commented May 30, 2018 at 12:07

SL8t7 · Accepted Answer · 2018-05-30 14:39:42Z

1

If anyone is interested, the fix was to change.

if (row[0] == "") {break;}

to

if (!row || row[0] == "") {break;}

Thanks for that LGSon.

answered May 30, 2018 at 14:39

SL8t7

6572 gold badges11 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Google Apps Script - How to break loop to prevent error message

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related