deleting pointer after return

Question

Matrix * Matrix::transpose()
{

    Matrix *m = new Matrix(*this->numCols, *this->numRows, false);

    for (int i = 0; i < *this->numRows; i++)
    {
        for (int j = 0; j < *this->numCols; j++)
        {
            m->setValue(j, i, this->getValue(i, j));
        }
    }

    return m;
}

Hello all. My memory keeps increasing after transposing matricies. How can i solve that, by deleting returned m(how to do it?) or deleting this->~Matrix() ?

The easiest thing to do would be to return a Matrix instead of a pointer to a newed object. — juanchopanza
– juanchopanza, Commented Jun 3, 2018 at 19:31
Try this maybe: stackoverflow.com/questions/13223399/deleting-a-pointer-in-c — unholy_me
– unholy_me, Commented Jun 3, 2018 at 19:31
You guys are so fast thank you for answering me! I will try both of them. — Barbaros Baturay
– Barbaros Baturay, Commented Jun 3, 2018 at 19:33
Why are you using manual memory management and not smart pointers? — Jesper Juhl
– Jesper Juhl, Commented Jun 3, 2018 at 19:34
@BarbarosBaturay No you don't need pointers of any type. Smart pointers aren't the solution when the problem is using dynamic allocation. The solution is to not use dynamic allocation. — juanchopanza
– juanchopanza, Commented Jun 3, 2018 at 19:38

MivVG · Accepted Answer · 2018-06-04 05:44:17Z

2

Just don't use any pointers. There is no reason to use new here. Just do

Matrix Matrix::transpose()
{

    Matrix m {*this->numCols, *this->numRows, false};

    for (int i = 0; i < *this->numRows; i++)
    {
        for (int j = 0; j < *this->numCols; j++)
        {
            m.setValue(j, i, this->getValue(i, j));
        }
    }

    return m;
}

Also another thing, why are you putting this everywhere? If you want to make clear something is a member, just prefix/postfix it like m_memberName, mMemberName or memberName_.

edited Jun 4, 2018 at 5:44

answered Jun 3, 2018 at 19:44

MivVG

7195 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Barbaros Baturay Over a year ago

Well, thank you for advice. Also i did somethink like void transpose and changing the values if the rows or cols are the same etc. Is it an efficient way ?

Millie Smith Over a year ago

Matrix m(*this->numCols, *this->numRows, false);

MivVG Over a year ago

Yes, that's even better. Editing now.

Collectives™ on Stack Overflow

deleting pointer after return

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related