C# should I close the streams when im using "using"?

Question

I have a service running on a server that zip files and I notice that each day the memory consumed increases, when I deployed it on the server it was consuming 3.6Mb, today, 3 months later it was consuming 180Mb.

This is part of the code that I'm using:

for (i = 0; i < files.Count; i++)
{
    try
    {
        if (File.Exists(@dir + zipToUpdate) && new FileInfo(@dir + zipToUpdate).Length < 104857600)
        {
            using (FileStream zipToOpen = new FileStream(@dir + zipToUpdate, FileMode.Open))
            {
                using (ZipArchive archive = new ZipArchive(zipToOpen, ZipArchiveMode.Update, false))
                {

                    if (File.GetCreationTime(@dir + files.ElementAt(i)).AddHours(FileAge) < DateTime.Now)
                    {
                        ZipArchiveEntry fileEntry = archive.CreateEntry(files.ElementAt(i));
                        using (BinaryWriter writer = new BinaryWriter(fileEntry.Open()))
                        {
                            using (FileStream sr = new FileStream(@dir + files.ElementAt(i), FileMode.Open, FileAccess.Read))
                            {
                                byte[] block = new byte[32768];
                                int bytesRead = 0;
                                while ((bytesRead = sr.Read(block, 0, block.Length)) > 0)
                                {
                                    writer.Write(block, 0, bytesRead);
                                    block = new byte[32768];
                                }
                            }
                        }
                        File.Delete(@dir + files.ElementAt(i));
                    }
                }
            }
        }
        else
        {
            createZip(files.GetRange(i, files.Count-i), dir + "\\", getZipName(dir, zipToUpdate));
            return;
        }
    }
    catch (Exception ex)
    {

        rootlog.Error(string.Format("Erro Run - updateZip: {0}", ex.Message));
    }
}

The creation of the zip or the update are similar so there is no point in paste both codes.

I do a recursive call of this for the folders inside and the service runs once each hour.

So, my question is if all these streams is what is making my memory usage increase month after month or if it can be something else.

If your using a using it auto closes once the loop is exited — Brad
– Brad, Commented Jun 8, 2018 at 16:15
Yeah, that's what I thought.. that's why I don't know why the memory is increasing... there could be any memory leak in this piece of code? — João Silva
– João Silva, Commented Jun 8, 2018 at 16:16
btw, if your using(var foo=woo) statment contains only another using, you can omit the brackets for much tidier code. — spender
– spender, Commented Jun 8, 2018 at 16:16
@JoãoSilva Rather than attempting to guess where a memory leak is (potentially) happening, run your program through a memory profiler. My guess is that GC is just being lazy, but without proper measurement, I'm guessing and you're guessing. — spender
– spender, Commented Jun 8, 2018 at 16:19

Mureinik · Accepted Answer · 2018-06-08 16:18:09Z

1

The using statement takes care of closing the IDisposable object that it opens. This is not the source of the potential memory leak you're observing.

answered Jun 8, 2018 at 16:18

Mureinik

316k54 gold badges402 silver badges406 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

C# should I close the streams when im using "using"?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related