Different result executing the same function [C++]

Question

Hello and thanks in advance. I need to create a Tetris project in C++, i have the boards and pieces classes but i want to do an initializer class, so what im doing is this

#include "Initializer.h"

void Initializer::drawBoard()
{

}

// --------------------------------- Public Part ----------------------- //

Initializer::Initializer(Board *bBoard, Pieces *pPieces)
{

}

void Initializer::drawScene()
{
    bBoard->showBoard();
}

Here is the board class:

Board::Board(Pieces *mPieces)
{
    for(int x = 0; x < 20; x++)
    {
      for(int y = 0; y < 10; y++)
      {
        mBoard[x][y] = 0;
      }
    }
}

void Board::showBoard()
{
    for(int x = 0; x < 20; x++)
    {
        for(int y = 0; y < 10; y++)
        {
          if(mBoard[x][y] == 0)
          {
            cout << 0;
          }
          else
          {
            cout << "x";
          }
        }
        cout << endl;
    }

}

and the main function

#include "Pieces.h"
#include "Board.h"
#include "Initializer.h"
#include <iostream>
using namespace std;



int main(int numeroArgumentos, char *argumentos[])
{
  srand (time(NULL));
  int randomNumber = rand() % 6;
  Pieces mPieces;
  Board bBoard(&mPieces);
  Initializer iIOS(&bBoard, &mPieces);
  bBoard.showBoard();
  iIOS.drawScene();
  return 0;
}

the problem is, i get two different results when i execute the main function as you can see in the image (bBoard.showBoard is the left result, and the other one is the iIOS.drawScene())

What i have to do to get the correct board with the two functions?

Your Initializer constructor doesn't do anything with its arguments. — aschepler
– aschepler, Commented Jun 15, 2018 at 22:48

MPops · Accepted Answer · 2018-06-15 22:50:45Z

1

What you're getting is undefined behavior. Your constructor for Initializer isn't actually capturing the values in board, so it's presumably just running through memory that doesn't belong to it.

answered Jun 15, 2018 at 22:50

MPops

3653 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Barmar · Accepted Answer · 2018-06-15 23:49:00Z

1

The Initializer constructor needs to save its parameters in the appropriate member variables. Just naming the parameters the same as the member variables doesn't do this automatically. You can use a member initializer list to do this.

Initializer::Initializer(Board *bBoard, Pieces *pPieces): bBoard(bBoard), pPieces(pPieces) {}

answered Jun 15, 2018 at 23:49

Barmar

789k57 gold badges555 silver badges669 bronze badges

Collectives™ on Stack Overflow

Different result executing the same function [C++]

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related