Laravel update/edit using foreach loop

Question

I was trying to update my table but I couldn't make it work.. I always end up with the error:

Invalid argument supplied for foreach()

Here is my Controller:

 public function show_score($id)
    {

        $scores = Score::with(['lead','subject'])->where(['subject_id'=>$id])->get();

        return view('markbook.show_score',compact('scores'));
    }

    public function update_score(Request $request)
    {
        $id = $request->input('id');

         $scores = Score::find($id);
         foreach ($scores as $datas) {
         $datas->jan_ap=$request->input('jan_ap');
         $datas->jan_hm=$request->input('jan_hm');
         $datas->save();  

        }


    }

route:
Route::get('markbook/scores/{id}', 'MarkbookController@show_score' );
Route::post('markbook/scores', 'MarkbookController@update_score');

Here is my table I'm trying to loop the updated score:

Score::find($id); finds one item/row, what are you trying to loop over here? — user8034901
– user8034901, Commented Jul 12, 2018 at 7:30

rkj · Accepted Answer · 2018-07-12 09:01:17Z

From chat discussion what found is that you want to update multiple scores, which is listed in tr, td. You can change it like this

Change in view

@foreach($scores as $score) 
    <tr> 
        <td>{{$score->lead->student_name}} <input type="hidden" name="scores[{{$loop->index}}][id]" value="{{$score->id}}"></td> 
        <td><input type="text" name="scores[{{$loop->index}}][jan_ap]" value="{{$score->jan_ap}}"></td> 
        <td><input type="text" name="scores[{{$loop->index}}][jan_hm]" value="{{$score->jan_hm}}"></td> 
    </tr> 
@endforeach

Controller update score

public function update_score(Request $request) 
{ 
    $scores = $request->input('scores');  //here scores is the input array param 

    foreach($scores as $row){
        $score = Score::find($row['id']); 
        $score->jan_ap = $row['jan_ap']; 
        $score->jan_hm = $row['jan_hm']; 
        $score->save(); 
    }
}

WebDevB · Accepted Answer · 2018-07-12 07:37:40Z

1

Using Score::find($id) you're only ever going to return 1 result so there won't be anything to foreach over.

If you just want to update a single row in the table you don't need to foreach it.

You can simply run

$score = Score::find($request->input($id));
$score->jan_ap = $request->input('jan_ap');
$score->jan_hm = $request->input('jan_hm');
$score->save();

if you want to return multiple rows you need to change your find to a get()

so $scores = Score::where('something', $request->input('something))->get();

If you want to update every row in the table with the same information you'd do a:

$scores = Score::all();

That would return every row in the table.

edited Jul 12, 2018 at 7:37

answered Jul 12, 2018 at 7:34

WebDevB

4922 gold badges8 silver badges27 bronze badges

6 Comments

Grace Over a year ago

how bout multiple rows example two student

WebDevB Over a year ago

Then you need to chance your find to a get();

Grace Over a year ago

do i still need the for each loop?

WebDevB Over a year ago

Yes, if you're returning multiple rows.

lagbox Over a year ago

side note: if you pass an array/Arrayable to find you will get a collection

|

Collectives™ on Stack Overflow

Laravel update/edit using foreach loop

2 Answers 2

Comments

6 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related