Can't access Post request data from request.data in Django

Question

I'm having a lot difficulty accessing the post request data sent from my Angular server. Somehow Response(data) still returns the body of my post request accurately, however I can't access the content inside to create instance of my model. Below is my code

Angular end:

let header = new HttpHeaders({
  'Authorization': ' JWT ' + this.authToken,
  'Content-Type': 'application/json',
});

let body = {
  "var1": var1,
  "var2": var2,
};

return new Promise(resolve => {
  this.http.post(this.server, body, {headers: header, withCredentials: true}).subscribe(data => {
    console.log(data);
    resolve(data);
  }, err => {
    console.log(err);
  });
});

Django

@api_view(['POST'])
@parser_classes((JSONParser,))
def order_processing(request):
    permission_classes = (permissions.IsAuthenticated,)
    data = request.data
    item = Item.create(data["var1"])
    item.save()
    return Response(data)

and I always end up getting the error:

TypeError at /post/↵create() missing 1 required positional argument:

which I think is due to data["var1"] being unavailable. Item is my custom model.

class Item(models.Model):
    # Fields
    var1 = models.TextField(editable=False)

    # Methods
    def __str__(self):
        return self.var1

    def create(self, var1):
        order = self.create(var1=var1)
        return order

On my localhost, I tried to use httpie to request and both Querydict and request.data are empty. But then Response(data) on my deployed server is still able to return the correct body so I don't know what exactly is the problem with it.

Any help would be appreciated.

create is not class method ( probably - unless you did it yourself). Try to do this : Item.objects.create(<data>) — Enthusiast Martin
– Enthusiast Martin, Commented Jul 24, 2018 at 15:20
@Sylph there's already a create method in ModelManager, putting a create method on the instance will only confuse everyone. Better to stick to the framework's conventions. — bruno desthuilliers
– bruno desthuilliers, Commented Jul 24, 2018 at 15:23

Enthusiast Martin · Accepted Answer · 2018-07-24 15:42:20Z

1

As i mentioned in the comment - your create method is not classmethod. So you can't call it like you do. Because it can be called only on a instance.

But, the create is not going to work like you'd like.

Do this instead:

remove the create method from your model
in your view do this : item = Item.objects.create(var1=data['var1'])

This will create the item.

Also another thing: your permission_classes don't do anything.

Instead, import the decorator:

from rest_framework.decorators import permission_classes

And change it to:

@api_view(['POST'])
@permission_classes((permissions.IsAuthenticated,))
@parser_classes((JSONParser,))
def order_processing(request):
   ....

edited Jul 24, 2018 at 15:42

answered Jul 24, 2018 at 15:26

Enthusiast Martin

3,0912 gold badges14 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Daniel Roseman Over a year ago

The first part of your answer is correct, but the stuff about permission_classes is totally wrong; you should delete it.

Enthusiast Martin Over a year ago

@DanielRoseman hm.areyou sure? i dont see how the request can be authenticated after it enters the function ( the permission classes variable in the original impl. is not going to be used ).

Daniel Roseman Over a year ago

You're right, now that you've removed the syntax error the code is fine.

Sylph Over a year ago

Thank you! I've tried your implementation and it works perfectly!

Collectives™ on Stack Overflow

Can't access Post request data from request.data in Django

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related