Default request mapping method picked up for other URLs with Path variable

Question

I have a @RestController below as below. The method getTrain(long) is supposed to be picked up for URLs http://localhost:8080/trains/1 but instead it's picking up getTrains(). The other URLs work fine as expected. I am not sure if I am missing or not understanding something. I also looked at Spring request mapping to a different method for a particular path variable value and it helped a bit.

Requirements: 1. /trains [POST] - add train 2. /trains [GET] - get all trains 3. /trains/{trainId} - get train by id

@RestController
public class TrainController {

    @Autowired
    private TrainService trainService;

    @RequestMapping(headers = { "Accept=application/json" }, method = RequestMethod.POST)
    public TrainDto addTrain(@RequestBody TrainDto trainDto) throws Exception {

        return trainService.addTrain(trainDto);
    }

    @RequestMapping(method = RequestMethod.GET)
    public List<TrainDto> getTrains() throws Exception {

        return trainService.getTrains();
    }

    @RequestMapping(value = "{trainId:\\d+}", method = RequestMethod.GET)
    public TrainDto getTrain(@PathVariable("trainId") long trainId) throws Exception {

        return trainService.getTrain(trainId);
    }
}

have you tried "/{trainId:\\d+} by appending a /?

Jayesh
– Jayesh

2018-08-30 05:48:19 +00:00
Commented Aug 30, 2018 at 5:48 — Jayesh
– Jayesh, Commented Aug 30, 2018 at 5:48

tharanga-dinesh · Accepted Answer · 2018-08-30 08:39:20Z

1

You should add value = "" to mapping request. See if this works

@RestController public class TrainController {

    @Autowired
    private TrainService trainService;

    @RequestMapping(value = "/trains",headers = { "Accept=application/json" }, method = RequestMethod.POST)
    public TrainDto addTrain(@RequestBody TrainDto trainDto) throws Exception {

        return trainService.addTrain(trainDto);
    }

    @RequestMapping(value = "/trains",method = RequestMethod.GET)
    public List<TrainDto> getTrains() throws Exception {

        return trainService.getTrains();
    }

    @RequestMapping(value = "/trains/{trainId}", method = RequestMethod.GET)
    public TrainDto getTrain(@PathVariable("trainId") long trainId) throws Exception {

        return trainService.getTrain(trainId);
    }

}

Or you can do it this way.

@RestController
@RequestMapping(TrainController.REQUEST_MAPPING_URL)
public class TrainController {

       public static final String REQUEST_MAPPING_URL = "/trains";

        @Autowired
        private TrainService trainService;

        @RequestMapping(value = "/",headers = { "Accept=application/json" }, method = RequestMethod.POST)
        public TrainDto addTrain(@RequestBody TrainDto trainDto) throws Exception {
            return trainService.addTrain(trainDto);
        }

        @RequestMapping(value = "/",method = RequestMethod.GET)
        public List<TrainDto> getTrains() throws Exception {
            return trainService.getTrains();
        }

        @RequestMapping(value = "/{trainId}", method = RequestMethod.GET)
        public TrainDto getTrain(@PathVariable("trainId") long trainId) throws Exception {
            return trainService.getTrain(trainId);
        }

    }

edited Aug 30, 2018 at 8:39

answered Aug 30, 2018 at 5:58

tharanga-dinesh

5677 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

FourtyTwo Over a year ago

Hi, this is a train app. So the URL already has trains to it. Doing it like this would result in /trains/trains/{trainId}

tharanga-dinesh Over a year ago

I cannot see it in your code. where are you put "/trains" ?

FourtyTwo Over a year ago

Wow, I tried it and it worked. Can you may be explain why it is not also appending the app name as part of the root url?

FourtyTwo Over a year ago

Both worked. I forgot that with Spring boot apps, the context path does not default to the app name

tharanga-dinesh Over a year ago

@FourtyTwo then you can accept as right answer. The HTTP method parameter has no default – so if we don’t specify a value, it’s going to map to any HTTP request.

Alien · Accepted Answer · 2018-08-30 06:19:20Z

0

@RestController
public class TrainController {

    @Autowired
    private TrainService trainService;

    @RequestMapping(headers = { "Accept=application/json" }, method = RequestMethod.POST)
    public TrainDto addTrain(@RequestBody TrainDto trainDto) throws Exception {

        return trainService.addTrain(trainDto);
    }

    @RequestMapping(method = RequestMethod.GET)
    public List<TrainDto> getTrains() throws Exception {

        return trainService.getTrains();
    }

    @RequestMapping(value = "{trainId}", method = RequestMethod.GET)
    public TrainDto getTrain(@PathVariable("trainId") long trainId) throws Exception {

        return trainService.getTrain(trainId);
    }
}

This would work. The value inside curly braces i.e. trainId should map to PathVariable.

edited Aug 30, 2018 at 6:19

Alien

16k8 gold badges43 silver badges64 bronze badges

answered Aug 30, 2018 at 5:50

Rimi Gandhi

112 bronze badges

Collectives™ on Stack Overflow

Default request mapping method picked up for other URLs with Path variable

2 Answers 2

5 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related