AngularJS foreach not able to find function within same Service

Question

need some help, for the life of me I can't get this to work. I'm trying to loop through an array which is within a config value and then trigger another function within the service I created, but I get an error

TypeError: Cannot read property 'registerToken' of undefined

Is there not a better way to do this it feels very clunky?

CampaignService.ts

import { ServerConfig } from "../core/ServerConfig";

declare var config: ServerConfig;

export class CampaignService {
  static $inject = ["localStorageService"];

  constructor(
    public localStorageService: angular.local.storage.ILocalStorageService
  ) {

  }             

  launchCampaign(campaignToken: string) {
    if (campaignToken) {
      config.campaigns.forEach(function (data) {
        if (campaignToken == data.title) {
          if (data.enabled) {
            this.registerToken(campaignToken);
          }
        }
      });
    }
  };

  registerToken(campaignToken: string) {

  }    

}

Sajeetharan · Accepted Answer · 2018-09-01 17:53:47Z

1

You need to use an arrow function which have the context,

 config.campaigns.forEach((data) => {
        if (campaignToken == data.title) {
          if (data.enabled) {
            this.registerToken(campaignToken);
          }
        }
 });

answered Sep 1, 2018 at 17:53

Sajeetharan

223k65 gold badges370 silver badges409 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

EugeneDeWaal Over a year ago

Awesome thanks @sajeetharan small things that had me for hours. I see this also seems to work var obj = config.campaigns.find(function (obj) { return obj.title === campaignToken; });

Sajeetharan Over a year ago

Great if that helped

EugeneDeWaal · Accepted Answer · 2018-09-01 18:04:48Z

0

After some investigation I found this to be the best shorthand might be wrong, comments welcome

import { ServerConfig } from "../core/ServerConfig";

declare var config: ServerConfig;

export class CampaignService {
  static $inject = ["localStorageService"];

  constructor(
    public localStorageService: angular.local.storage.ILocalStorageService
  ) {

  }             

  launchCampaign(campaignToken: string) {
    if (campaignToken) {
       (config.campaigns.find(function (obj) { return obj.title === campaignToken; })) ? this.registerToken(campaignToken) : void (0);
    }
  };

  registerToken(campaignToken: string) {

  }    

}

answered Sep 1, 2018 at 18:04

EugeneDeWaal

2282 silver badges17 bronze badges

Comments

Farhan Nayyer · Accepted Answer · 2018-09-03 05:36:01Z

0

Another way of doing it will be passing outer "this" to the forEach function, then the foreach have "this" context defined.

Something like:

config.campaigns.forEach(function (data) {
    if (campaignToken == data.title) {
      if (data.enabled) {
        this.registerToken(campaignToken);
      }
    }
}, this);

You can refer the documentation of foreach here.

answered Sep 3, 2018 at 5:36

Farhan Nayyer

631 silver badge5 bronze badges

Collectives™ on Stack Overflow

AngularJS foreach not able to find function within same Service

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related