C# ThreadPool QueueUserWorkItem Exception Handling

Question

Whenever a thread in my ThreadPool throws an exception, my code seems to be stuck at the catch block inside the thread function. How do I get the exception back to the main thread?

possible duplicate of How to catch exceptions from a ThreadPool.QueueUserWorkItem? — Henrik
– Henrik, Commented Mar 7, 2011 at 9:49
those methods dont work. I get an exception saying The calling thread must be STA, because many UI components require this. — Aks
– Aks, Commented Mar 7, 2011 at 9:51
Ok, it might be worth posting some code. This sounds like you're possibly accessing a GUI component from a non-GUI thread. — Nick
– Nick, Commented Mar 7, 2011 at 9:52
I am accessing a listbox to add the exception from the thread. If I throw directly its stuck in the thread catch block, it wont go back to the main thread — Aks
– Aks, Commented Mar 7, 2011 at 9:55

Unmesh Kondolikar · Accepted Answer · 2016-11-03 18:49:14Z

7

The best practice is that your background threads should not throw exceptions. Let them handle their exceptions on their own.

Ideally you should wrap the code in your method that executes on a thread in a try-catch block and handle the exception in the catch block. Do not re-throw it from the catch block.

Read this for more details. http://www.albahari.com/threading/#_Exception_Handling

If you want to update the UI from background thread you can do that by using Control.InvokeRequired property and Control.Invoke method. See the MSDN links for details and examples.

edited Nov 3, 2016 at 18:49

answered Mar 7, 2011 at 9:51

Unmesh Kondolikar

9,2924 gold badges41 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Aks Over a year ago

But my UI has to display the exception. What can I do?

David Mårtensson Over a year ago

Catch it in the thread and use a queue (pipe) to send a message back to the UI thread to display the error. Exceptions over thread borders is a bad thing and very hard to trouble shot.

Brent Worden · Accepted Answer · 2015-02-04 20:14:28Z

It's not possible to transfer exception from a thread to another one. What can you do is to built some synchronization mechanism to transfer exception information between threads and then throw a new exception from the target thread something like:

class Program
{
    Exception _savedException = null;
    AutoResetEvent _exceptionEvent = new AutoResetEvent(false);

    static void Main(string[] args)
    {
        Program program = new Program();
        program.RunMain();
    }

    void RunMain()
    {
        ThreadPool.QueueUserWorkItem(new WaitCallback(ThreadMethod));

        while (true)
        {
            _exceptionEvent.WaitOne();
            if (_savedException != null)
            {
                throw _savedException;
            }
        }
    }

    void ThreadMethod(object contxt)
    {
        try
        {
            // do something that can throw an exception
        }
        catch (Exception ex)
        {
            _savedException = ex;
            _exceptionEvent.Set();
        }
    }
}

If you have a Win form application things are much simpler. In the catch clause of your thread use Invoke (or BeginInvoke) method of your form, providing it with the exception details. In the method launched with Invoke you can rethrow or treat your exception as you want.

Collectives™ on Stack Overflow

C# ThreadPool QueueUserWorkItem Exception Handling

2 Answers 2

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related