returning whole string in Python; Remove None

Question

I am a beginner in Python and I want to remove all Capital numbers from the string. I have tried below code but getting None after each function call. What should I return from the function?

def remove_capitals(a_string):
    for latter in a_string:

        if not (ord(latter) in range(65,91)):
            print(latter,end="")
        else:
            continue

print(remove_capitals("A1B2C3D"))
print(remove_capitals("Georgia Institute of Technology"))

I am getting below Output

123None
eorgia nstitute of echnologyNone

your function is missing the optional return statement so it returns the default None. if the print happens inside the function, remove it from outside and just do remove_capitals("A1B2C3D"). Otherwise, instead of printing inside, return it and print it outside., — Ma0
– Ma0, Commented Sep 5, 2018 at 11:47
Your function already prints(), then returns None. You then print that return value. — Martijn Pieters
– Martijn Pieters, Commented Sep 5, 2018 at 11:47
Either return a single result at the end of your function and not print inside the function, or remove the print() calls around remove_capitals(). — Martijn Pieters
– Martijn Pieters, Commented Sep 5, 2018 at 11:47

Cory Kramer · Accepted Answer · 2018-09-05 11:47:28Z

2

You can use a generator expression with in str.join to remove all uppercase letters, which are enumerated in string.ascii_uppercase

from string import ascii_uppercase
def remove_capitals(a_string):
    return ''.join(i for i in a_string if i not in ascii_uppercase)

>>> print(remove_capitals("A1B2C3D"))
123
>>> print(remove_capitals("Georgia Institute of Technology"))
eorgia nstitute of echnology

answered Sep 5, 2018 at 11:47

Cory Kramer

119k19 gold badges176 silver badges233 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Martijn Pieters Over a year ago

Much faster: no_caps = dict.fromkeys(range(65, 91)) then return a_string.translate(no_caps).

Ma0 Over a year ago

you could pass a list to join instead of a generator to speed it up. Otherwise, +1

DSM Over a year ago

not in ascii_uppercase means that for any lowercase letter you have to loop over every character in ascii_uppercase. Couldn't you just use not char.isupper()?

Martijn Pieters Over a year ago

@DSM: that'd expand the possible characters that are removed, when the input uses codepoints outside of ASCII.

DSM Over a year ago

@MartijnPieters: say rather that it wouldn't limit the possible uppercase characters that are removed to the ones the OP hardcoded as "Capital numbers".

Rahul K P · Accepted Answer · 2018-09-05 12:08:11Z

1

Use isupper,

def remove_upper_case(x):
        return ''.join(i for i in x if not i.isupper())

Execution:

In [281]: remove_upper_case("Georgia Institute of Technology")
Out[281]: 'eorgia nstitute of echnology'

In [282]: remove_upper_case("A1B2C3D")
Out[282]: '123'

edited Sep 5, 2018 at 12:08

answered Sep 5, 2018 at 11:52

Rahul K P

16.2k4 gold badges40 silver badges56 bronze badges

1 Comment

bruno desthuilliers Over a year ago

No need for the list expression, a simple generator expression is enough.

Collectives™ on Stack Overflow

returning whole string in Python; Remove None

2 Answers 2

5 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related