else condition is not working for src attribute in jquery [duplicate]

Question

Been trying add alt text in the web page using jquery below code however able to get correct value for the 1st image but else if and else conditions are not working properly. Not able to add alt texts for the other images

$(document).ready(function() {

  $("img ").each(function() {
    var img = $(this);

    if (!img.attr("alt") || img.attr("src") === "/temp/iconcache/flags/32x32/flag_brazil.png")
      img.attr("alt", "Brazil Flag");
    else if (!img.attr("alt") || img.attr("src") === "/temp/iconcache/flags/32x32/flag_China.png")
      img.attr("alt", "China Flag");
    else {
      img.attr("alt", "");
    }
  });
});

Sort of the converse of stackoverflow.com/questions/42190142/…. — T.J. Crowder
– T.J. Crowder, Commented Sep 5, 2018 at 17:24
Here you go: $("img").each(function() { var img = $(this); if (!img.attr("alt") && img.attr("src") === "/temp/iconcache/flags/32x32/flag_brazil.png") img.attr("alt", "Brazil Flag"); else if (!img.attr("alt") && img.attr("src") === "/temp/iconcache/flags/32x32/flag_China.png") img.attr("alt", "China Flag"); else { img.attr("alt", ""); } }); You can also use indexOf to check if src contains a text. eg: if(!img.attr("alt") && img.attr("src").indexOf("flag_brazil.png") !== -1) — Prasanna Jathan
– Prasanna Jathan, Commented Sep 6, 2018 at 5:12

user229044 · Accepted Answer · 2018-09-05 17:24:33Z

1

You're using || when you want &&. Each of your conditions has if (!img.attr("alt") || ... which means that if the image's alt attribute is null, the remainder of the conditional expression will be ignored. This means a null alt will cause the first branch ("brazil") to be run, regardless of the value of the src attribute.

answered Sep 5, 2018 at 17:24

user229044♦

241k41 gold badges347 silver badges350 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jacob Over a year ago

You could also add an if (!img.attr('alt')) return; before the other ifs to short-circuit the rest of the code. That way you don't have to repeat that check.

Collectives™ on Stack Overflow

else condition is not working for src attribute in jquery [duplicate]

1 Answer 1

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Linked

Related