'System.OutOfMemoryException' in system.drawing.image

Question

i store my website image in form of byte array , but when i try to save them as jpeg file ,some of this file throw exception.here is my code for get image:

IList<PropertyInfo> properties = typeof(ApplicationUser).GetProperties()
                               .Where(x => x.PropertyType == typeof(Byte[])).ToList();

var imaBytes = property.GetValue(user, null) as Byte[];
if (imaBytes == null || imaBytes.Length == 0) continue;

Image userImage = ImageHelper.byteArrayToImage(imaBytes);   
userImage.Save(pathname + $@"\{DirName}\" + property.Name + ".jpg", ImageFormat.Jpeg);

and this is my ImageHelper.byteArrayToImage :

public static Image byteArrayToImage(byte[] byteArrayIn)
{
    try
    {
        using (MemoryStream ms = new MemoryStream(byteArrayIn))
        using (var image = Image.FromStream(ms,false,true))
        {
            byteArrayIn = new byte[0];
            return new Bitmap(image); 
        }
    }
    catch (Exception e)
    {
       Logger.log(e);
    }
}

edit:
i wrap MemoryStream and Image code with using statment and change my code and add ImageToDisk method :

public static void ImageToDisk(byte[] byteArrayIn, string pathToSave)
    {
        try
        {
            using (MemoryStream ms = new MemoryStream(byteArrayIn))
            {
                using (var image = Image.FromStream(ms, false, true))
                {
                    image.Save(pathToSave, ImageFormat.Jpeg);
                    image.Dispose();

                }

            }
        }
        catch (Exception e)
        {
            Logger.log(e);
            throw;
        }

    }

and main code is this:

 foreach (var property in properties)
                    {
                        try
                        {
                            var imaBytes = property.GetValue(user, null) as Byte[];
                            if (imaBytes == null || imaBytes.Length == 0)
                            {
                                continue;
                            }

                            ImageHelper.ImageToDisk(imaBytes, pathname + $@"\{DirName}\" + property.Name + ".jpg");

                        }
                        catch (Exception ex)
                        {
                            LogException(ex);
                        }
                    }

but now am getting system.runtime.interopservices.externalexception
EDIT 2:
i am completely dizzy!!! its seems some user upload images from IE and IE change MIME type to image/PJPEG

error occurred is some file with this MIME type but also some other image/PJPEG files save correctly without any exception
how can i resolve this error??

From earlier experience, the error checking in the image loading code is somewhat flawed so it may simply be that the image file is corrupt, or using extensions or compression methods that .NET doesn't support. For instance, if you have an image that says it is HUUGE then .NET will actually try to load the image and allocate the memory, instead of kicking back an exception. — Lasse V. Karlsen
– Lasse V. Karlsen, Commented Sep 11, 2018 at 12:03
One thing about your code though, why are you allocating two images, why not simply return Image.FromStream(...); instead of doing that in a using block and constructing a bitmap around it? — Lasse V. Karlsen
– Lasse V. Karlsen, Commented Sep 11, 2018 at 12:05
thank you for comment ,images are JPEG but some image are saved correctly! — Moshhegh Faghdan
– Moshhegh Faghdan, Commented Sep 11, 2018 at 12:06
@MoshheghFaghdan OOM are almost always caused because Dispose() wasn't called on objects that need disposing, lots of temporary objects (like those created by string operations) or frequent resizing of large arrays. All these create temporary objects that will be garbage collected at some point. In the mean time though they create a lot of memory fragmentation. The runtime may not be able to find a large enough block to allocate the new byte array or that new List — Panagiotis Kanavos
– Panagiotis Kanavos, Commented Sep 11, 2018 at 12:13

Paweł Dyl · Accepted Answer · 2018-09-11 12:34:24Z

3

some of this file throw exception

I'm almost sure the problem is with disposing your images. Make sure all resources are released:

using (Image userImage = ImageHelper.byteArrayToImage(imaBytes))
{
  //do whatever you need
  userImage.Save(pathname + $@"\{DirName}\" + property.Name + ".jpg", ImageFormat.Jpeg);
}

Bitmaps consume a lot of memory. Under the hood Image uses GdipLoadImageFromStream method. To release resources, it should be paired with GdipDisposeImage. That's what happens inside Image.Dispose() method.

edited Sep 11, 2018 at 12:34

answered Sep 11, 2018 at 12:09

Paweł Dyl

9,1831 gold badge13 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

nvoigt Over a year ago

Matter of fact the GDI code does not distinguish and throws OOM exceptions even for things like "not enough handles", so not disposing could indeed be a culprit here.

Moshhegh Faghdan Over a year ago

i don't test code yet , but its seem to work correctly ,but what real image was png format?? is error cause for incorrect image format??

Paweł Dyl Over a year ago

No, image format is not important. Just make sure userImage is disposed correctly.

Moshhegh Faghdan Over a year ago

@PawełDyl i try it but currently it exception thrown 'system.runtime.interopservices.externalexception' in system.drawing.dll

Collectives™ on Stack Overflow

'System.OutOfMemoryException' in system.drawing.image

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related