event handling in c# .net winform application which uses sql server

Question

i have a combobox with a list of SQLusers, which have permissions granted from beforehand. a table PERMISSION_DETAIL with columns username, permission_name consists the details of permissions granted or denied

now when a user selects a SQLuser from combobox then the permissions are shown as a checkbox, like if permission is already granted, then the checkbox appears and its tick is checked, else UNCHECKED.

for this i use:

if(permission is previously granted)

checkbox1.checked = true;   // here the Checkbox_CheckChanged event is called, but i dont want to call it.
checkbox1.enabled = false;

now, besides the checkbox, there is a button, on clicking it, the checkbox gets enabled, that is, to modify the permission, the user will click the button.

now the user will tick or untick the checkbox to grant or deny permission and the checkbox change event

will be called, this would be fine.

i want that as the checkbox appears, its tick is automatically checked, but this calls the checkbox_Checkchanged event, but i dont want to call that event.

do not add any flag variables to form. it will difficult(hard work) to control it if project is great. look at my post — AEMLoviji
– AEMLoviji, Commented Mar 8, 2011 at 10:38

AEMLoviji · Accepted Answer · 2011-03-08 10:40:59Z

2

i advice you to change Checkbox_CheckChanged event to Checkbox_Click event.

private void Checkbox_Click(object sender, EventArgs e)
        {
            if ((sender as CheckBox).Checked)
            {
                MessageBox.Show("checked");
                // add role to user
            }
            else
            {
                MessageBox.Show("un_checked");
                /remove role ffrom user
            }
        }

edited Mar 8, 2011 at 10:40

answered Mar 8, 2011 at 10:31

AEMLoviji

3,2779 gold badges41 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

cederlof · Accepted Answer · 2011-03-08 10:26:25Z

1

You could check if the checkbox is enabled, before doing anything in the EventHandler:

protected void Checkbox_CheckChanged (object sender, ..EventArgs e)
{
    //return if not enabled
    if(!((CheckBox)sender).IsEnabled) return;

    //DO THE REST
}

I think that if you make an event handler for CheckChanged, it should be called always when "check is changed", and you should handle logic thereafter.

answered Mar 8, 2011 at 10:26

cederlof

7,4294 gold badges49 silver badges67 bronze badges

2 Comments

sqlchild Over a year ago

sir, if i use: if(checkbox1.enabled==true) --then is there any difference? i mean in your posted query and this one?

cederlof Over a year ago

@sqlchild: no, there's no difference. (CheckBox)sender is the same as checkbox1 in this example. My code makes it "safer" i you later want to change the name of checkbox1, as it will work with any name.

Josh Smeaton · Accepted Answer · 2011-03-08 10:27:37Z

1

The event is going to be called regardless, what matters is how you handle that event. An event has occurred, you can't pretend it hasn't. The only thing you can do is decide whether that event means anything to you at a particular point in time.

For example:

public void chkPermission_CheckChanged(object sender, EventArgs e)
{
    bool isChecked = chkPermission.Checked;
    if (this.user.HasPermission() == isChecked) { return; }
    // otherwise, we need to change some permissions!
}

Analyse whether or not you need to do anything, and go from there. Don't just blindly assume something needs to change because an event fired.

answered Mar 8, 2011 at 10:27

Josh Smeaton

48.8k24 gold badges137 silver badges166 bronze badges

Comments

richard · Accepted Answer · 2011-03-08 10:25:16Z

-1

Add a boolean variable, IsCheckboxEventShouldFire, to your form. Set to true initially. In the code that sets the checkbox to checked automatically, also now set IsCheckboxEventShouldFire to false. In the checkchanged event, first check if the IsCheckboxEventShouldFire is true. If it is, run your code. If not, then don't. Set IsCheckboxEventShouldFire to true at the end of the event's code.

answered Mar 8, 2011 at 10:25

richard

12.6k23 gold badges102 silver badges154 bronze badges

2 Comments

Josh Smeaton Over a year ago

Adding yet another boolean flag in this case is a bad idea. The check value should be compared against the current permission state of the user in question. Otherwise, your flag will become out of sync.

richard Over a year ago

I disagree. You assume he wants to check to see what the mission is. I'm assuming he wants to check to see if the event was fired because of a user action or if it was caused by code. In that case, a boolean variable is the answer.

Collectives™ on Stack Overflow

event handling in c# .net winform application which uses sql server

4 Answers 4

Comments

2 Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related