Why doesn't this javascript code process this xml file?

Question

I'm using this code:

<script type="text/javascript">
if (window.XMLHttpRequest)
{
xmlhttp=new XMLHttpRequest();
}
else
{
xmlhttp=new ActiveXObject("Microsoft.XMLHTTP");
}
xmlhttp.open("GET","css/galerii.xml",false)
xmlhttp.send();
xmlDoc=xmlhttp.responseXML;
alert(xmlDoc.getElementsByTagName("GALERIE")[0].childNodes[0].nodeValue);
</script>

to process some xml:

<?xml version="1.0" encoding="UTF-8" ?>
<GALERIES>
<GALERIE>
info
</GALERIE>

<GALERIE>
other info
</GALERIE>
</GALERIES>

But I get nothing in the alert and shouldn't xmlhttp.open("GET","css/galerii.xml",false) have a value if it's successful ? It's undefined. There's a root node now, same result.

JAAulde · Accepted Answer · 2011-03-08 18:45:47Z

2

You have no root node (document element), which is a requirement in XML.

<?xml version="1.0" encoding="UTF-8" ?>
<GALERIES>
  <GALERIE>
    info
  </GALERIE>

  <GALERIE>
    other info
  </GALERIE>
</GALERIES>

You also have no onreadystatechange method for your AJAX request. When your code which reads the responeXML executes, the http request for the XML has yet to return. You need to read up on how to build AJAX requests: https://developer.mozilla.org/en/xmlhttprequest

Working example: http://jsfiddle.net/2F8q6/1/

Your JS modified to work as the example does:

<script type="text/javascript">
    if (window.XMLHttpRequest)
    {
        xmlhttp=new XMLHttpRequest();
    }
    else
    {
        xmlhttp=new ActiveXObject("Microsoft.XMLHTTP");
    }

    xmlhttp.open( "GET","css/galerii.xml", false );

    xmlhttp.onreadystatechange = function()
    {
        if( xmlhttp.readyState === 4 && xmlhttp.status === 200 )
        {
            xmlDoc=xmlhttp.responseXML;
            alert(xmlDoc.getElementsByTagName("GALERIE")[0].childNodes[0].nodeValue);
        }
    }

    xmlhttp.send();
</script>

edited Mar 8, 2011 at 18:45

answered Mar 8, 2011 at 18:07

JAAulde

19.5k5 gold badges56 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Kesarion Over a year ago

I got the same result even with a root node.

Kesarion Over a year ago

Thank you for the answer. I made a new page just with this script in the body and I get nothing. What could be wrong. By the way shouldn't xmlhttp.open( "GET","css/galerii.xml", false ); have true as the third parameter ? I tried both ways but still nothing.

JAAulde Over a year ago

At this point I don't know what else may be wrong with your script. If you're able to make a version of the broken script available for access online, shoot me a link and I'll take a look.

Kesarion Over a year ago

I tried putting another alert inside the if() and I didn't get a response so I thought one of the conditions is never met. I deleted xmlhttp.status === 200 and it went through I got my alert but not the xml alert. Any ideas ? What alternatives do I have if this doesn't work ?

JAAulde Over a year ago

readyState of 4 means the request is complete, status is the HTTP status that was returned from the server. When readyState is 4, if status is not 200 something went wrong with the request. What are you getting for status when readyState is 4?

|

Andrey Adamovich · Accepted Answer · 2011-03-08 18:06:05Z

1

XML document may only have one root element.

answered Mar 8, 2011 at 18:06

Andrey Adamovich

20.7k16 gold badges97 silver badges133 bronze badges

Comments

Lightness Races in Orbit · Accepted Answer · 2011-03-08 18:10:08Z

1

You need a single root element.

<?xml version="1.0" encoding="UTF-8" ?>
<GALERIES>
  <GALERIE>
    info
  </GALERIE>
  <GALERIE>
    other info
  </GALERIE>
</GALERIES>

answered Mar 8, 2011 at 18:10

Lightness Races in Orbit

387k77 gold badges672 silver badges1.1k bronze badges

Comments

Vivek Goel · Accepted Answer · 2011-03-08 18:06:51Z

0

fix your xml . your xml is not valid. there is no root element in your xml. try here http://www.w3schools.com/Dom/dom_validate.asp.

answered Mar 8, 2011 at 18:06

Vivek Goel

24.4k30 gold badges119 silver badges194 bronze badges

Collectives™ on Stack Overflow

Why doesn't this javascript code process this xml file?

4 Answers 4

7 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

7 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related