Managing cookies with Javascript

Question

I have tried to create a popup manager using Javascript, the idea is to display the ajax popup only once. For some reason the popup appears more than once and randomly. I would like to know if there is something wrong with my code:

 function SetCookie(name, value, days) {
     var expire = new Date ();
     expire.setTime (expire.getTime() + (24 * 60 * 60 * 1000) * days);
     document.cookie = name + "=" + escape(value) + "; expires=" +expire.toGMTString();
 }
 function GetCookie(name) {
   var startIndex = document.cookie.indexOf(name);
  if (startIndex != -1) {
      var endIndex = document.cookie.indexOf(";", startIndex);
      if (endIndex == -1) endIndex = document.cookie.length;
      return unescape(document.cookie.substring(startIndex+name.length+1, endIndex));
  }
  else {
      return null;
  }
 }

function DeleteCookie(name) {
    var expire = new Date ();
    expire.setTime (expire.getTime() - (24 * 60 * 60 * 1000));
    document.cookie = name + "=; expires=" + expire.toGMTString();
}

 function Pop() {
    var cookie = GetCookie("popup");
    if(cookie==null) {
        SetCookie("popup",1,300);
 }
    else {
        if(cookie==1) {
            new Ajx.Dialog();
            SetCookie("popup",2,300);
            return false;
        }
        else {
            return false;
        }
    }
  }
  window.onload = Pop;

Based on the code you provided you don't appear to have defined a SetCookie function. — johnhunter
– johnhunter, Commented Mar 9, 2011 at 11:40

johnhunter · Accepted Answer · 2011-03-09 12:10:32Z

1

Ok, so what is happening is this:

function Pop() {
    var cookie = GetCookie("popup");
    if(cookie==null) {
        SetCookie("popup",1,300);
    }
    else {
        if(cookie==1) { 
            new Ajx.Dialog();
            SetCookie("popup",2,300);
            return false;
        }
        else {
            return false;
        }
    }
}

First visit and cookie is null. Cookie is set to 1 and pop function exits.
Second visit and cookie is 1. Ajx.Dialog called, cookie set to 2, pop function returns false.
Third visit and cookie is 2. pop function returns false.

Is this what you intended?

UPDATE:

I'm not sure what you want to happen, but if you want the popup to fire once on first visit then use the following:

function Pop() {
    var cookie = GetCookie("popup");
    if(cookie != 1) {
        new Ajx.Dialog();
        SetCookie("popup", 1, 300);
    }
}

edited Mar 9, 2011 at 12:10

answered Mar 9, 2011 at 12:00

johnhunter

1,83615 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Roch Over a year ago

Thank you for your answer, yes my idea is to display the popup only on the second pageview

johnhunter Over a year ago

OK. I found your pop function worked as you expected on Firefox 3.6 and see no reason why it wouldn't work on other browsers.

Collectives™ on Stack Overflow

Managing cookies with Javascript

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related