Get data from http call inside for loop in an Angular 2+ app

Question

I want to call my http request inside a for loop because I only want to execute 1000 items at a time. So I have the following code:

getData(IDs: string[]): Observable<any> {
    // IDs is a large array of strings, about 3000 of them

    const results = [];
    const totalData = [];

    // split the IDs array into chunks of 1000
    while (IDs.length) {
      results.push(IDs.splice(0, 1000));
    }

    // loop through the new array with the chunks of 1000 and run the http request
    for (let i = 0; i < results.length; i++) {
      const data = this.http.get(`myhttprequest/${results[i]}`);

      totalData.push(data);
    }

    console.log(totalData); 
    // this is just an array of observables when I am looking for an array of data

    return totalData
}

I'm not getting any errors, but instead of returning an array data, it's just returning an array of observables.

I know it;s because the variables are updating before the data is returned so I've tried using promises and unfortunately I cant get that to work.

How can I get this function to return data instead of observables?

You have to subscribe to get to send the request.

gr4viton
– gr4viton

2018-10-02 08:51:51 +00:00
Commented Oct 2, 2018 at 8:51 — gr4viton
– gr4viton, Commented Oct 2, 2018 at 8:51

gr4viton · Accepted Answer · 2018-10-02 08:58:04Z

1

Always subscribe!

An HttpClient method does not begin its HTTP request until you call subscribe() on the observable returned by that method. This is true for all HttpClient methods.

Reference link.

answered Oct 2, 2018 at 8:58

gr4viton

1,5141 gold badge11 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

cup_of Over a year ago

yeah I cant believe I didnt subscribe, I've done this a million times lol I guess I need some sleep

gr4viton Over a year ago

It happens with all of us. Take a break. Drink a coffee. :)

Collectives™ on Stack Overflow

Get data from http call inside for loop in an Angular 2+ app

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related