PHP Function is echoing - but I only asked to `return`

Question

I'm working on a small function for a WordPress site, and can't figure why my function is echoing the data on my webpage.

My function is:

function get_post_titles($args) {
    $titles = array();
    $posts = new WP_Query($args);
    while ($posts->have_posts()){
        $posts->the_post();
        $titles[] = the_title();
    }
    return $titles;
}

and I call it in a separate .php file:

<?php
$titles = get_post_titles($args);
?>
<select>
    <option selected="selected">Choose an Article</option>
    <?php
        foreach($titles as $title){
            ?> <option> $title </option><?php //this isn't working, pls ignore for this post
        }   
    ?>
</select>
...

The result is a webpage with a Select box (yay!) but for some reason, the page also shows ALL of the titles in a row (it outputs the full array).

I would expect that if I had say, echo get_post_titles($args), but nowhere in my code do I ask it to echo. Why is my array visible?

I think it's because of my $titles = get_post... line. But again, why is it displaying $titles instead of simply declaring/assigning the variable?

_{(I know there's a WordPress SE site, but I think this is more directly a PHP issue than WP issue. However, if I should post over there instead, let me know).}

Look at 3rd parameter codex.wordpress.org/Function_Reference/the_title — AbraCadaver
– AbraCadaver, Commented Oct 3, 2018 at 17:15

Xhynk · Accepted Answer · 2018-10-03 17:29:22Z

2

the_title() displays the title. You should use get_the_title() instead.

edited Oct 3, 2018 at 17:29

Xhynk

13.9k8 gold badges36 silver badges72 bronze badges

answered Oct 3, 2018 at 17:14

Gavin Simpson

2,8623 gold badges32 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

BruceWayne Over a year ago

Whelp that's exactly it! I studied my code for about an hour, and even learned yesterday about get_the_[whatever] vs the_[whatever] and completely overlooked that somehow...Thanks so much for pointing me in the right direction! :D

Gavin Simpson Over a year ago

My pleasure. As the other answer shows... many ways to skin a cat. I just prefer the lazy route, i.e. less typing, but both work.

Madhur Bhaiya · Accepted Answer · 2018-10-03 17:17:56Z

2

From Wordpress Documentation, following is the usage of the_title:

the_title( $before, $after, $echo );

$echo (Boolean) (optional) Display the title (TRUE) or return it for use in PHP (FALSE).

Default: TRUE

You can do the following (set the third argument to false):

$titles[] = the_title('','',false);

answered Oct 3, 2018 at 17:17

Madhur Bhaiya

28.9k10 gold badges53 silver badges61 bronze badges

2 Comments

BruceWayne Over a year ago

Thanks very much for the expanded info!

Madhur Bhaiya Over a year ago

@BruceWayne happy to help :)

Collectives™ on Stack Overflow

PHP Function is echoing - but I only asked to `return`

2 Answers 2

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related