Loop back through AJAX function - Causing infinite loop

Question

I am so so stuck with this. I have a functionA which I want to call functionB (my API call) and have it return the results of the data. The API is a "queue" and "get" type. It should run like this:

Run API query with "queue" type
Collect returned reportID
Run API query with "get" type and reportID
Collect data into myfunction

This is my current code:

function myfunction() {
  var ref;
  var type = "queue";
  var metric = "pageviews";
  var post = getReport(ref, type, metric);
    post.done(function (r) {
        console.log (r);
        }
    );
}

function getReport(ref, type, metric) {
   return $.ajax({
        url: "report.php", 
        dataType: 'json',
        data: { 
            ref: ref,
            type: type, 
            metric: metric
        }
    });
}

This works fine. However I can't get the loop working correctly for the second part of my query. This is what I tried:

function myfunction() {
  var ref;
  var type = "queue";
  var metric = "pageviews";
  var post = getReport(ref, type, metric);
    post.done(function (r) {
        if (type == "queue")
        {
        myfunction(r.reportID,"get");
        }
        else if (type == "get")
        {
        console.log(r);
        }
    );
}

I keep overwriting the value of type which seems to cause an infinite loop.

where do you change the value of type from queue to get — blaz
– blaz, Commented Oct 9, 2018 at 10:13
@ThoVu when I call the function myfunction(r.reportID,"get"); — Jimbob
– Jimbob, Commented Oct 9, 2018 at 10:16
But even if I put this back into the function it still gets overwritten. — Jimbob
– Jimbob, Commented Oct 9, 2018 at 10:17
You are trying to solve a problem that shouldn't exist in the first place. Why do you want to have that recursive myfunction call in there? And when you do myfunction(r.reportID,"get"); the "get" is simply ignored completely. Not only has myfunciton no arguments, even if it did, you're shadowing type by hardcoding it to "queue"- — user5734311
– user5734311, Commented Oct 9, 2018 at 10:18

score 1 · Accepted Answer · 2018-10-09 10:41:08Z

1

Here's a basic solution that chains (actually: nests) the API calls:

function myfunction(ref) {
  getReport(ref, "queue", "pageviews").done(function(r1) {
    getReport(r1.reportID, "get", null).done(function(r2) {
      console.log(r2);
    })
  });
}

function getReport(ref, type, metric) {
  return $.getJSON("report.php", {
    ref: ref,
    type: type,
    metric: metric
  });
}

(I'm guessing how your API works / what it returns but it should be easy enough to fit)

edited Oct 9, 2018 at 10:41

answered Oct 9, 2018 at 10:24

user5734311

Sign up to request clarification or add additional context in comments.

1 Comment

Jimbob Over a year ago

Thank you Chris, that's great

Collectives™ on Stack Overflow

Loop back through AJAX function - Causing infinite loop

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related