Pointer to an array of vectors in c++ and send it to a function

Question

I want to define an array of vectors in c++. Normally I can do it like this:

vector <pair<int,int> > G[100];

I have a function that read data from a file.

My first problem is that I want to define G with size V that read from a file and G should define in main but calling a function with an uninitialized pointer can't work.

My Second problem is when I define G like this:

vector <pair<int, int> > *G;
G = new vector <pair<int, int>>[10];

it doesn't read data correctly (it doesn't work correctly).

Here is my code:

void readData(vector <pair<int, int> > *G)
{
    int V, E;
    ifstream file("input.txt");
    file >> V >> E;
    //G = new vector <pair<int, int>>[V]; //my problem
    for (int i = 0; i < E; i++)
    { 
        int u, v, w;
        file >> u >> v >> w; 
        G[u - 1].push_back(make_pair(v - 1, w)); 
        G[v - 1].push_back(make_pair(u - 1, w)); 
    }
    file.close();
}
int main() {
    vector <pair<int, int> > *G;
    G = new vector <pair<int, int>>[10]; // my problem
    MST = new vector <pair<int, int>>;
    readData(G);
}

Example data:

and this code is working correctly and read data from console:

const int N=10;
vector <pair<int,int> > G[N];
int main() {    
    cin >> V>>E;
    for(int i=0; i<E; i++){
        int u,v,w;
        cin >>u>>v>>w; 
        G[u-1].push_back(make_pair(v-1,w)); 
        G[v-1].push_back(make_pair(u-1,w)); 
    }
}

One or two things: * Don't accept the Vector as pointer, but instead use a reference. * Why should one create an array of vecs? Could you give please the usecase for this? Use a hashmap if you want a key-value relationship, or a std::array for a fixed array. — hellow
– hellow, Commented Oct 15, 2018 at 12:28
Why do you a raw array of vectors? Use a vector of vectors instead. — Jabberwocky
– Jabberwocky, Commented Oct 15, 2018 at 12:28
@Galik @Jobberwoky Yes, I can use a vector of vectors. But it doesn't my problem. If I change an array of vectors to a vector of vectors I should edit some functions that use G. — Karim Pazoki
– Karim Pazoki, Commented Oct 15, 2018 at 12:46
@KarimPazoki Just pass those functions G.data() to pass the internal array that the vector manages. — Galik
– Galik, Commented Oct 15, 2018 at 12:47

Galik · Accepted Answer · 2018-10-15 12:46:11Z

2

There is no reason to use a builtin array when using a vector does exactly what you want. For example you could do this:

void readData(std::vector<std::vector<std::pair<int, int>>>& G)
{
    std::size_t V, E;
    std::ifstream file("input.txt");
    file >> V >> E;
    //G = new vector <pair<int, int>>[V]; //my problem
    G.resize(V); // solved!!!
    for (std::size_t i = 0; i < E; i++)
    {
        std::size_t u, v, w;
        file >> u >> v >> w;
        G[u - 1].push_back(std::make_pair(v - 1, w));
        G[v - 1].push_back(std::make_pair(u - 1, w));
    }
    file.close();
}
int main() {
    std::vector<std::vector<std::pair<int, int>>> G;
//    G = new vector <pair<int, int>>[10]; // my problem
//    MST = new vector <pair<int, int>>;
    readData(G);
}

answered Oct 15, 2018 at 12:46

Galik

49k5 gold badges85 silver badges126 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jabberwocky · Accepted Answer · 2018-10-15 13:26:00Z

You probably should use a vector or vectors instead of a raw array of vectors.

Example:

#include <iostream>
#include <fstream>
#include <vector>

using namespace std;

void readData(vector<vector <pair<int, int>>> & G)
{
  int V, E;
  ifstream file("input.txt");

  file >> V >> E;
  G.resize(V);

  for (int i = 0; i < E; i++)
  {
    int u, v, w;
    file >> u >> v >> w;
    G[u - 1].push_back(make_pair(v - 1, w));
    G[v - 1].push_back(make_pair(u - 1, w));
  }
  file.close();
}

int main() {
  vector<vector <pair<int, int>>> G;
  readData(G);

  for (auto & v1 : G)
  {
    for (auto & p : v1)
    {
      cout << p.first << ", " << p.second << "\n";
    }

    cout << "\n";
  }
}

Output:

Hints:

don't use all capital variable names, and use meaningful variable names, e.g: data instead of G, nbvectors instead of V and nblines instead of E etc.
using namespace std; is not very good practice, but I didn't change the OP's code too much.

Iago Carvalho · Accepted Answer · 2018-10-15 12:33:06Z

0

My first problem is that I want to define G with size V that read from a file and G should define in main but calling a function with an uninitialized pointer can't work.

You don't need to define the size of G. It's possible to simply declare the vector and add your pairs using the push_back function, as in the code below.

vector <pair<int, int>> G;
while (readFile) {
    G.push_back(make_pair(item1, item2));
}

edited Oct 15, 2018 at 12:33

answered Oct 15, 2018 at 12:23

Iago Carvalho

4101 gold badge5 silver badges16 bronze badges

2 Comments

Karim Pazoki Over a year ago

G is an array of vectors. this answer is not correct. please read end of question and this code is working correctly and read data from console:

Karim Pazoki Over a year ago

@lago Carvalho add includes. #include <iostream> #include <vector> #include<fstream> using namespace std;

Max Langhof · Accepted Answer · 2018-10-15 12:47:10Z

My first problem is that I want to define G with size V that read from a file and G should define in main but calling a function with an uninitialized pointer can't work.

Quick and dirty fix: Pass a reference to the pointer:

void readData(vector <pair<int, int> >*& G)

Then your main can do this:

vector<pair<int, int>>* MST;
readData(MST);

Then readData cand (and will) change the pointer value (because you passed it by reference).

The better way: Don't use bare C-arrays. Use a vector.

void readData(vector<vector<pair<int, int>>>& G)
{
    size_t V, E;
    ifstream file("input.txt");
    file >> V >> E;
    G.resize(V);

    // Your code...
}

main()
{
    vector<vector<pair<int, int>>> MST;
    readData(MST);
}

//G = new vector <pair<int, int>>[V]; //my problem

That's not the real problem. The problem is that your function takes a vector <pair<int, int> > *G and you overwrite that pointer value it in the above line. The same would happen if your function would take an int and you would just overwrite it: In either case, the caller of the function does not see the change.

void foo(int x) {
  x = 10; // Caller will not see this change.
}

The fix is the same as above: Pass a reference instead.

Serge Rogatch · Accepted Answer · 2018-10-15 12:27:51Z

-1

You can rewrite your function to return the vector instead:

vector <pair<int, int> >* readData()
{
    int V, E;
    ifstream file("input.txt");
    file >> V >> E;
    vector <pair<int, int> > *G = new vector <pair<int, int>>[V];
    for (int i = 0; i < E; i++)
    { 
        int u, v, w;
        file >> u >> v >> w; 
        G[u - 1].push_back(make_pair(v - 1, w)); 
        G[v - 1].push_back(make_pair(u - 1, w)); 
    }
    file.close();
    return G;
}
int main() {
    MST = new vector <pair<int, int>>;
    vector <pair<int, int> > *G = readGraph();
}

answered Oct 15, 2018 at 12:27

Serge Rogatch

15.3k9 gold badges101 silver badges186 bronze badges

4 Comments

Karim Pazoki Over a year ago

I don't know why. But it doesn't work correctly. I want to have an array like this: 0->|< 2,4>,<1,3>| 1->|<0,3>,<3,6>,<4,21>| ....

François Andrieux Over a year ago

In modern c++, scenarios where using new for dynamic allocation is the right solution are very rare. This is not one of them. Just about any time you feel tempted you write new T[x] you can substitute it with a std::vector<T>.

François Andrieux Over a year ago

I've retracted my down vote, since this is what OP is actually looking for. But I can't upvote an answer that provides bad advice. Pointing out the problems with the solution or providing a good alternative would complete this answer.

Serge Rogatch Over a year ago

I'm not going to teach the OP the whole C++ at once. Let him first learn to return values from functions.

Collectives™ on Stack Overflow

Pointer to an array of vectors in c++ and send it to a function

5 Answers 5

Comments

Comments

2 Comments

Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

2 Comments

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related