"IF loop not working in EXCEL Macros"

Question

Private Sub CommandButton1_Click()
  TextBox2.Value = 10
  TextBox3.Value = 5
  TextBox2.Value = (CInt(TextBox2))
  TextBox3.Value = (CInt(TextBox3))

  If TextBox2.Value > TextBox3.Value Then
    ActiveSheet.Select
    UserForm5.Show
  End If
End Sub

The control is not going in the IF loop, and "USerForm5 is not getting displayed.

Can anyone pls help.

Reagrds

Most likely that TextBox.Value property cannot hold an integer and converts it back to string. Nice little gotcha. — MPelletier
– MPelletier, Commented Mar 13, 2011 at 8:02
It is common in StackOverflow to Accept answers that work by selecting the large tick. An up vote is always good, too. Answers that help, but do not solve the problem can also be up-voted. You will find notes in the FAQ in the top bar. — Fionnuala
– Fionnuala, Commented Mar 13, 2011 at 11:14

David Heffernan · Accepted Answer · 2011-03-13 08:01:45Z

4

The comparison is being done as strings. Wrap the CInt() calls around the values in the IF statement and you'll be good.

TextBox2.Value = 10
TextBox3.Value = 5
If CInt(TextBox2.Value) > CInt(TextBox3.Value) Then

edited Mar 13, 2011 at 8:01

answered Mar 13, 2011 at 7:48

David Heffernan

616k46 gold badges1.1k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

"IF loop not working in EXCEL Macros"

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related